Repository navigation
ci: move native macOS tests to Xcode 27 - #155
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesMoves native macOS CI to Xcode 27, selects Go 1.27.2, and adds a read-only release snapshot mode. Example: Dispatch release.yml on main with tag v0.4.0 and dry_run: true.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-directed PR adds useful CI and release verification behavior absent from main; no actionable patch defect was found. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherGitHub Actions selects compilers and runs native tests or builds Linux connector archives; tag releases retain the existing publication path. flowchart TD
A[GitHub workflow event] --> B[Native macOS tests]
B --> C[Xcode 27 runner]
A --> D[Release mode selection]
D --> E[Read-only snapshot]
D --> F[Tag publication]
E --> G[Go 1.27.2 build]
F --> G
Technical reviewBest possible solution: Retain the separate read-only snapshot path and patched compiler while preserving tag publication and the existing Swift CodeQL runner. Do we have a high-confidence way to reproduce the issue? This is maintenance rather than a runtime bug reproduction; GitHub independently records successful execution of the changed native workflow on the reviewed head. Is this the best way to solve the issue? The focused runner substitution and isolated snapshot job preserve existing owners and publication behavior without introducing unnecessary production machinery. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against e7f18d7c31f3. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 18, 2026, 7:27 PM ET / 23:27 UTC. |
Move native macOS tests from
macos-26to GitHub'sxcode-27Apple Silicon runner. Keep Swift CodeQL onmacos-26with the documented tracing exception. The app and vendored library still explicitly target macOS 14 and 11, respectively; no Intel-only job exists.The required vulnerability scan reproduced nine reachable Go standard-library advisories with Go 1.27.1. Select the patched Go 1.27.2 toolchain while retaining the
go 1.26.0source minimum. Both release jobs pin Go 1.27.2 as well, so retrying a historical tag cannot select its vulnerable compiler.Add a separate read-only release snapshot job for
dry_run: true. It builds current main with GoReleaser's snapshot/publish-disabled mode and skips the existing publishing job. The regular tag-release path remains intact. No release, tag, version bump, or manual deployment is part of this PR.Validation: two independent Codex autoreviews are clean through P2; actionlint and all three existing CodeQL contract tests passed. The native Swift DES known-answer and concurrency tests passed under
nice -n 19with two build jobs. On AWS Crabbox, the patched vulnerability scan is clean andpnpm check,pnpm test(223 tests), andpnpm test:native(Go race tests and vet on Linux) all passed in runrun_7924a78e0b54cb0858dcf6a9f4a6a51d; leasecbx_c2e6bdb903cais stopped. Full native app proof comes from the PR macOS workflow. Open Dependabot alerts and dependency-bot PRs are both zero.After exact-head CI and merge, verify main CI and dispatch the read-only release dry run with the current published tag, v0.4.0.
Exact-head CI passed at
ef495ecdcf122a8be560a7a17c40c0ab6c5c541b: native macOS https://github.com/openclaw/crabfleet/actions/runs/39175622166, CodeQL https://github.com/openclaw/crabfleet/actions/runs/39175622153, connector https://github.com/openclaw/crabfleet/actions/runs/39175622177, Worker https://github.com/openclaw/crabfleet/actions/runs/39175622321.