Skip to content

ci: move native macOS tests to Xcode 27 - #155

Merged
steipete merged 2 commits into
mainfrom
ci/macos27-s17-20261018
Oct 18, 2026
Merged

steipete merged 2 commits into
mainfrom
ci/macos27-s17-20261018

Conversation

@steipete

@steipete steipete commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Move native macOS tests from macos-26 to GitHub's xcode-27 Apple Silicon runner. Keep Swift CodeQL on macos-26 with the documented tracing exception. The app and vendored library still explicitly target macOS 14 and 11, respectively; no Intel-only job exists.

The required vulnerability scan reproduced nine reachable Go standard-library advisories with Go 1.27.1. Select the patched Go 1.27.2 toolchain while retaining the go 1.26.0 source minimum. Both release jobs pin Go 1.27.2 as well, so retrying a historical tag cannot select its vulnerable compiler.

Add a separate read-only release snapshot job for dry_run: true. It builds current main with GoReleaser's snapshot/publish-disabled mode and skips the existing publishing job. The regular tag-release path remains intact. No release, tag, version bump, or manual deployment is part of this PR.

Validation: two independent Codex autoreviews are clean through P2; actionlint and all three existing CodeQL contract tests passed. The native Swift DES known-answer and concurrency tests passed under nice -n 19 with two build jobs. On AWS Crabbox, the patched vulnerability scan is clean and pnpm check, pnpm test (223 tests), and pnpm test:native (Go race tests and vet on Linux) all passed in run run_7924a78e0b54cb0858dcf6a9f4a6a51d; lease cbx_c2e6bdb903ca is stopped. Full native app proof comes from the PR macOS workflow. Open Dependabot alerts and dependency-bot PRs are both zero.

After exact-head CI and merge, verify main CI and dispatch the read-only release dry run with the current published tag, v0.4.0.

Exact-head CI passed at ef495ecdcf122a8be560a7a17c40c0ab6c5c541b: native macOS https://github.com/openclaw/crabfleet/actions/runs/39175622166, CodeQL https://github.com/openclaw/crabfleet/actions/runs/39175622153, connector https://github.com/openclaw/crabfleet/actions/runs/39175622177, Worker https://github.com/openclaw/crabfleet/actions/runs/39175622321.

@steipete
steipete requested a review from a team as a code owner October 18, 2026 23:12
@clawsweeper

clawsweeper Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T23:14:32.112922Z 82c7acd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 18, 2026
@clawsweeper

clawsweeper Bot commented Oct 18, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

Moves native macOS CI to Xcode 27, selects Go 1.27.2, and adds a read-only release snapshot mode.

Example: Dispatch release.yml on main with tag v0.4.0 and dry_run: true.

  • Before: The workflow only offers the publishing path and checks out the release tag.
  • After: A separate read-only job builds the selected source as a snapshot without publishing.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) Useful, focused maintenance with no identified defect; native workflow execution is verified, but release-path execution remains unobserved.
Proof confidence 🌊 off-meta tidepool Not applicable: The maintainer-authored exemption applies; GitHub confirms the changed native workflow ran successfully on xcode-27, while the release snapshot remains unexercised in the supplied evidence and artifact-log access was blocked.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Maintainers need current native CI, patched release compilers, and a release build check that cannot publish assets.
Reason: The supplied maintainer-authored classification establishes direction, and the implementation preserves deployment floors and existing release semantics.

Merge readiness

✅ Ready for maintainer review

Keep open: this maintainer-directed PR adds useful CI and release verification behavior absent from main; no actionable patch defect was found.

Priority: P2
Reviewed head: ef495ecdcf122a8be560a7a17c40c0ab6c5c541b

Before merge

None.

Findings

None.

Tests

  • Missing end-to-end proof: The new release snapshot dispatch and historical-tag build with Go 1.27.2 have not been demonstrated in the supplied evidence.
Agent review details

How this fits together

GitHub Actions selects compilers and runs native tests or builds Linux connector archives; tag releases retain the existing publication path.

flowchart TD
  A[GitHub workflow event] --> B[Native macOS tests]
  B --> C[Xcode 27 runner]
  A --> D[Release mode selection]
  D --> E[Read-only snapshot]
  D --> F[Tag publication]
  E --> G[Go 1.27.2 build]
  F --> G
Loading

Technical review

Best possible solution:

Retain the separate read-only snapshot path and patched compiler while preserving tag publication and the existing Swift CodeQL runner.

Do we have a high-confidence way to reproduce the issue?

This is maintenance rather than a runtime bug reproduction; GitHub independently records successful execution of the changed native workflow on the reviewed head.

Is this the best way to solve the issue?

The focused runner substitution and isolated snapshot job preserve existing owners and publication behavior without introducing unnecessary production machinery.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against e7f18d7c31f3.

Provenance checked

  • Native macOS test runner changes intended behavior with a stated reason (281e21f: Provide scoped CI for vendor and app native tests.)
  • Go toolchain selection changes intended behavior with a stated reason (d1905a5: Refresh dependencies while retaining the Go 1.26 source minimum and selecting a preferred compiler.)
  • Historical release retries changes intended behavior with a stated reason (c00eb5b: Check out the requested tag before building and publish its exact changelog notes.)
  • Swift CodeQL runner keeps the original intent (ec33952: Analyze first-party Swift through an explicit arm64 package build.)

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

Likely related people:

  • Peter Steinberger: Raw commit 281e21f adds .github/workflows/macos-tests.yml:27 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 281e21f9121f; files: .github/workflows/macos-tests.yml)
  • Vincent Koc: Raw commit ec33952 adds .github/workflows/codeql.yml:78 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: ec33952bac50; files: .github/workflows/codeql.yml)

Labels

Label changes:

  • add P2: Compiler patching and CI maintenance have clear value without evidence of an urgent deployed-user regression.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P2: Compiler patching and CI maintenance have clear value without evidence of an urgent deployed-user regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Use the documented read-only dispatch with v0.4.0 to verify snapshot building and confirm the publishing job is skipped.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 18, 2026, 7:27 PM ET / 23:27 UTC.

@steipete
steipete merged commit 6e562bf into main Oct 18, 2026
12 of 13 checks passed
@steipete
steipete deleted the ci/macos27-s17-20261018 branch October 18, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant