Repository navigation
fix: reject compromised eMudhra keys in Rust clients - #157
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. What this changesUpdates the Rust client's certificate verifier and bundled roots to reject disclosed eMudhra incident keys. Example: A TLS peer presents an emSign intermediate with a compromised public key under an otherwise trusted chain.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Blocked before merge - 1 item remains Keep this PR open: main still pins advisory-affected TLS dependencies, and the focused security update remains necessary; the previous changelog finding is resolved. Priority: P1 Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherThe native Rust client and Rust web gateway send account credentials and signaling tokens through HTTPS and secure WebSocket transports whose TLS dependencies authenticate upstream peers. flowchart LR
Native[Native Rust viewer] --> Cloud[Cloud account and signaling]
Browser[Browser viewer] --> Gateway[Rust web gateway]
Cloud --> TLS[TLS peer verification]
Gateway --> TLS
TLS --> Upstream[Account and signaling services]
Technical reviewBest possible solution: Retain the focused upstream dependency repair and distribute replacement Rust builds after verifying the production TLS boundary. Do we have a high-confidence way to reproduce the issue? Main selects advisory-affected versions through Rustls transports, establishing the affected source path when configured trust anchors permit the compromised chain; this review did not execute an exploit. Is this the best way to solve the issue? Updating the owning lockfile to the upstream patched releases is the smallest complete repair, and the tempfile dependency normalization remains within its published requirement. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 8f1e8a8ebe6e. Provenance checked
TestingProof path: none. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes: No label changes. Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (1 earlier review cycle)
Reviewed October 21, 2026, 5:06 AM ET / 09:06 UTC (Revision 2). |
|
Added the required Unreleased changelog line; only CHANGELOG.md changed from the reviewed dependency update. The lead reran all three required pnpm gates successfully on this head; validation and platform limits are current in the PR body. @clawsweeper re-review |
|
🦞👀 Re-review progress:
|
What Problem This Solves
The experimental Rust client's locked TLS dependencies can accept chains containing the compromised eMudhra intermediate keys.
User Impact
Future native Rust client builds consume WebPKI 0.103.16 and webpki-root-certs 1.0.10. Existing built clients still need replacement builds. Platform-native/custom-store behavior and deployment remain separate verification/update work; no protocol or application settings change.
Why This Change Was Made
Regenerate the owning lock with compatible released verifier/root-data fixes. Cargo also normalizes tempfile's allowed dependency edge from the existing getrandom 0.4.3 to existing 0.3.4; no additional package versions change. The Go connector's existing fixed compiler is independent. See the upstream WebPKI advisory and root-data advisory.
Evidence
pnpm check,pnpm test(223 tests) andpnpm test:native(Go race tests and vet) pass. The lead independently reran all three required pnpm gates.CertDistrustedafter it. This exact-library proof is shared with the core lock update; it does not substitute for macOS/Windows native verifier or authenticated application tests.git diff --checkpass.Landing qualification
Added the required dense Unreleased changelog line. The new head changes only
CHANGELOG.mdrelative to the reviewed dependency update. The lead reranpnpm check,pnpm test(223 passed), andpnpm test:native(Go race tests and vet passed) in the isolated Linux guest with that exact changelog; the first runner setup failed before tests and is not counted as passing proof. Prior Rust workspace and actual selected WebPKI verifier evidence remains applicable because dependency/source inputs are unchanged. macOS/Windows native verifier and authenticated product-flow limits above remain; the advisory expanded proof request identified no additional source defect. Existing main-push Worker deployments and configured migrations are authorized; no manual tag, release or deploy dispatch is initiated.