Repository navigation
fix(security): adopt patched workerd certificate rejection - #1264
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs changes before merge. What this changesThis PR pins the tracking worker’s local workerd engine to 1.20261021.1 and updates its locked platform packages. Example: A local Worker fetches https://dv-g3b-emudhra.we-have-a-problem.com/ using explicitly supplied historical trust roots.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Needs changes before merge - 1 item remains Keep this PR open: current main still selects the older workerd runtime, and the existing required changelog finding remains unresolved. Priority: P2 Before merge
Findings
Agent review detailsHow this fits togetherThe tracking worker’s separate pnpm workspace supplies Wrangler and Miniflare with a native workerd executable for local development; outbound HTTPS passes through that engine’s certificate verifier. flowchart LR
A[pnpm workspace override] --> B[Locked dependency graph]
B --> C[Wrangler and Miniflare]
C --> D[Native workerd]
D --> E[TLS certificate verification]
E --> F[HTTPS response or rejection]
Technical reviewBest possible solution: Land the focused dependency override with the repository-required Unreleased security note accurately limited to local workerd protection. Do we have a high-confidence way to reproduce the issue? The supplied native baseline evidence reproduces acceptance of all 14 incident chains by current main’s workerd 1.20261019.1 under explicit-only historical trust; macOS platform trust already rejects them. Is this the best way to solve the issue? The existing pnpm override boundary is the smallest complete consumer fix: it selects the patched engine without introducing an application verifier or changing package-manager ownership. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 563e30a205d9. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes: No label changes. Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (2 earlier review cycles)Reviewed October 26, 2026, 5:54 AM ET / 09:54 UTC (Revision 3). |
|
Native TLS proof supplement for final source This addresses the actual review by publishing retained native macOS ARM64 output. The shared candidate proof contains the complete exact-candidate 32-row matrix, all 14 successful independent chain+exact-hostname controls with DER/SPKI identities, both complete native rejection logs with matched error references, the executed fixture Worker/harness, historical-root hash, and public/private-CA positive controls. That is the same native candidate binary selected by this repository: SHA256 Source head
Historical CA SHA256 Observed boundary and limitation: The exact candidate's raw errors say The standalone fixture Worker exercises the actual installed native executable's outbound-fetch boundary; application bundle build/startup and owning gates below are separate evidence. This proves local development/test runtime adoption within macOS ARM64; it does not establish Cloudflare managed-fleet delivery, production deployment, other architectures or unrelated application features. Changelog disposition: I decline the P3 Unreleased edit under the maintainer's explicit campaign instruction that CHANGELOG.md is release-owned. The maintainer workflow likewise puts release-note context in the PR/commit. The repository's generic AGENTS.md requirement was inspected; the explicit task direction takes precedence. No review/security gate is waived. Release-note context: The tracking Worker's local development/test engine now uses workerd 1.20261021.1 to reject disclosed compromised eMudhra keys even under explicitly supplied historical trust roots. This does not deliver or qualify Cloudflare's managed production runtime. Exact source/native artifacts and installed resolver{
"head": "59bcfd9c0ad3dc2ad11a7371afcc5c7bcb193d7a",
"base": "563e30a205d911f7f2bd15f4504ee950e6e98cf2",
"patchSha256": "f1b7bd85a0da2b0074010b50600074fa1f6296e4160a72c40a460360df4e60fb",
"sourceFiles": [
{
"path": "internal/tracking/worker/pnpm-lock.yaml",
"sha256": "93c575ee59008a5861bc2c254ec0454711530041583553ea2857688a0493820e"
},
{
"path": "internal/tracking/worker/pnpm-workspace.yaml",
"sha256": "970182e2f65c97a597a53d947c87e0caf7b1589966875635d257a622222487b6"
}
],
"nativeArtifacts": [
{
"label": "gogcli-baseline",
"path": "<TASKROOT>/native-engine/baseline-gogcli/workerd",
"sha256": "3684a329a3d598a1e5879ee3cf74d8fd88cc0ab9639905f25a305aa9e0d57ea0",
"version": "workerd 2026-10-19"
},
{
"label": "candidate",
"path": "<TASKROOT>/native-engine/1.20261021.1/workerd",
"sha256": "44a06c31a6578f234cdf7f23219b88978c8d8d21cb8ce85795cab53614b50d64",
"version": "workerd 2026-10-21",
"npmIntegrity": "sha512-OZ6Qkc9EwNl6kOyEBBQIOmOsbIfWCeR7F6h0EcScdjQLIB6drsmSpEZuBC3gAgz/eqDqjDrDCbPAA7jDllxIMw==",
"tarballSha256": "0ffe5070b2494dad46121253e9268115bc94b37a69eb7283d3a05f5439c1ba06",
"metadataSha256": "a4e17e123709b78c21ff04a106c42acea0314259262f1e19d8f642e5f76e3d4e"
}
],
"installedResolver": {
"wrangler": "4.151.3",
"miniflareEntry": "<TASKROOT>/gogcli/repo/internal/tracking/worker/node_modules/.pnpm/miniflare@5.20261019.1-beta/node_modules/miniflare/dist/src/index.js",
"workerdExecutable": "<TASKROOT>/gogcli/repo/internal/tracking/worker/node_modules/.pnpm/@cloudflare+workerd-darwin-arm64@1.20261021.1/node_modules/@cloudflare/workerd-darwin-arm64/bin/workerd",
"sha256": "44a06c31a6578f234cdf7f23219b88978c8d8d21cb8ce85795cab53614b50d64"
}
}All 32 retained baseline result rows (both trust modes, incident and legitimate controls){"engine":"gogcli-baseline","mode":"explicit-only","url":"https://example.com/","startedUtc":"2026-10-26T09:06:50.872503+00:00","result":{"ok":true,"status":200,"body":"<!doctype html><html lang=en><head><meta charset=utf-8><link rel=icon href=data:,><meta name=viewport content=\"width=dev"},"elapsedSeconds":0.035}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://localhost:19889/","startedUtc":"2026-10-26T09:06:50.908653+00:00","result":{"ok":true,"status":200,"body":"workerd-native-mac-private-positive"},"elapsedSeconds":0.004}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://dv-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:50.913385+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.173}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://dv-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:51.086523+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://ov-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:51.258510+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://ov-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:51.430436+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://ev-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:51.602323+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://ev-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:51.774340+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.173}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://dv-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:51.947798+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.17}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://dv-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:52.118550+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.17}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://ov-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:52.289918+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://ov-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:52.462685+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://ev-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:52.635069+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://ev-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:52.807654+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://dv-g3b-noct-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:52.980178+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.544}
{"engine":"gogcli-baseline","mode":"explicit-only","url":"https://dv-g3b-aaa-noct-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:53.524634+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.542}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://example.com/","startedUtc":"2026-10-26T09:06:54.182843+00:00","result":{"ok":true,"status":200,"body":"<!doctype html><html lang=en><head><meta charset=utf-8><link rel=icon href=data:,><meta name=viewport content=\"width=dev"},"elapsedSeconds":0.045}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://localhost:19889/","startedUtc":"2026-10-26T09:06:54.228569+00:00","result":{"ok":true,"status":200,"body":"workerd-native-mac-private-positive"},"elapsedSeconds":0.006}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://dv-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:54.234726+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = c3du1ugsti2th9e086jc6l11","stack":"Error: internal error; reference = c3du1ugsti2th9e086jc6l11\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":1.049}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://dv-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:55.284278+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = trib21u4u39adjpvgk98c4kd","stack":"Error: internal error; reference = trib21u4u39adjpvgk98c4kd\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.434}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://ov-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:55.718493+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = a4q1fshibrhj3reirqd2s7d3","stack":"Error: internal error; reference = a4q1fshibrhj3reirqd2s7d3\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.434}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://ov-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:56.153523+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = g0mit3ve1mr5tm4fcfh3bcvk","stack":"Error: internal error; reference = g0mit3ve1mr5tm4fcfh3bcvk\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.449}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://ev-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:56.602923+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = g46cv6qhr149mt8vn34honut","stack":"Error: internal error; reference = g46cv6qhr149mt8vn34honut\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.427}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://ev-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:57.030322+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = s7g60ieuvviodj7gcsr03f8o","stack":"Error: internal error; reference = s7g60ieuvviodj7gcsr03f8o\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.422}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://dv-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:57.453235+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = uv4h0hemk499i3h1l6ktgnuu","stack":"Error: internal error; reference = uv4h0hemk499i3h1l6ktgnuu\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.445}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://dv-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:57.898570+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = 5rrh4svfm32347ibd7sccpme","stack":"Error: internal error; reference = 5rrh4svfm32347ibd7sccpme\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.163}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://ov-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:58.062226+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = 702k4aoael9abebp9eq6hc6n","stack":"Error: internal error; reference = 702k4aoael9abebp9eq6hc6n\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.159}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://ov-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:58.221453+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = r8fcdldt2bkq761mbnmk2i05","stack":"Error: internal error; reference = r8fcdldt2bkq761mbnmk2i05\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.15}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://ev-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:58.372411+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = 6kq0no1nc4g7cqsqa5prs7fo","stack":"Error: internal error; reference = 6kq0no1nc4g7cqsqa5prs7fo\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.15}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://ev-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:58.522980+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = rkdlj2ukqg9da5hnjnnps0a0","stack":"Error: internal error; reference = rkdlj2ukqg9da5hnjnnps0a0\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.151}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://dv-g3b-noct-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:58.674317+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = sjaas5j2q67l0errh80aulff","stack":"Error: internal error; reference = sjaas5j2q67l0errh80aulff\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.414}
{"engine":"gogcli-baseline","mode":"system-plus-explicit","url":"https://dv-g3b-aaa-noct-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:59.088659+00:00","result":{"ok":false,"name":"Error","error":"internal error; reference = ulbfk1btt06a04u999d8q1da","stack":"Error: internal error; reference = ulbfk1btt06a04u999d8q1da\n at async Object.fetch (worker.js:1:164)"},"elapsedSeconds":0.412}Actual frozen baseline install{
"repo": "gogcli",
"stage": "baseline-install",
"command": [
"pnpm",
"install",
"--frozen-lockfile",
"--store-dir",
"<TASKROOT>/gogcli/pnpm-store"
],
"exitCode": 0,
"elapsedSeconds": 4.825,
"runtime": "v26.12.1",
"bun": "1.4.4",
"packageRoot": "<TASKROOT>/gogcli/repo/internal/tracking/worker",
"artifacts": [
{
"path": "<TASKROOT>/gogcli/repo/internal/tracking/worker/node_modules/.pnpm/@cloudflare+workerd-darwin-arm64@1.20261019.1/node_modules/@cloudflare/workerd-darwin-arm64/bin/workerd",
"sha256": "3684a329a3d598a1e5879ee3cf74d8fd88cc0ab9639905f25a305aa9e0d57ea0",
"version": "workerd 2026-10-19"
}
],
"recordedUtc": "2026-10-26T09:04:35.814650+00:00"
}Candidate install and exact resolution{
"repo": "gogcli",
"commands": [
{
"command": [
"pnpm",
"install",
"--lockfile-only",
"--ignore-scripts",
"--store-dir",
"<TASKROOT>/gogcli/pnpm-store"
],
"exitCode": 0,
"elapsedSeconds": 2.205
},
{
"command": [
"pnpm",
"install",
"--frozen-lockfile",
"--store-dir",
"<TASKROOT>/gogcli/pnpm-store"
],
"exitCode": 0,
"elapsedSeconds": 3.65
}
],
"artifacts": [
{
"path": "<TASKROOT>/gogcli/repo/internal/tracking/worker/node_modules/.pnpm/@cloudflare+workerd-darwin-arm64@1.20261019.1/node_modules/@cloudflare/workerd-darwin-arm64/bin/workerd",
"sha256": "3684a329a3d598a1e5879ee3cf74d8fd88cc0ab9639905f25a305aa9e0d57ea0",
"version": "workerd 2026-10-19"
},
{
"path": "<TASKROOT>/gogcli/repo/internal/tracking/worker/node_modules/.pnpm/@cloudflare+workerd-darwin-arm64@1.20261021.1/node_modules/@cloudflare/workerd-darwin-arm64/bin/workerd",
"sha256": "44a06c31a6578f234cdf7f23219b88978c8d8d21cb8ce85795cab53614b50d64",
"version": "workerd 2026-10-21"
}
],
"identityExit": 0,
"identity": "{\"wrangler\":\"4.151.3\",\"miniflareEntry\":\"<TASKROOT>/gogcli/repo/internal/tracking/worker/node_modules/.pnpm/miniflare@5.20261019.1-beta/node_modules/miniflare/dist/src/index.js\",\"workerdExecutable\":\"<TASKROOT>/gogcli/repo/internal/tracking/worker/node_modules/.pnpm/@cloudflare+workerd-darwin-arm64@1.20261021.1/node_modules/@cloudflare/workerd-darwin-arm64/bin/workerd\",\"sha256\":\"44a06c31a6578f234cdf7f23219b88978c8d8d21cb8ce85795cab53614b50d64\"}\n",
"recordedUtc": "2026-10-26T09:09:55.687097+00:00",
"lockSha256": "93c575ee59008a5861bc2c254ec0454711530041583553ea2857688a0493820e"
}Owning validation commands and actual exit results[
{
"command": [
"make",
"worker-ci"
],
"label": "worker-ci",
"exitCode": 0,
"elapsedSeconds": 4.019
},
{
"label": "dry-run",
"command": [
"pnpm",
"run",
"build"
],
"exitCode": 0,
"elapsedSeconds": 0.822
}
]Actual local product startup/result (decoded GIF response text encoded as UTF8-base64, not original wire bytes){
"repo": "gogcli",
"stage": "candidate",
"command": [
"wrangler",
"dev",
"--local",
"--ip",
"127.0.0.1",
"--port",
"19916",
"--inspector-port",
"19917",
"--persist-to",
"<TASKROOT>/gogcli/state/candidate"
],
"startedUtc": "2026-10-26T09:14:29.401402+00:00",
"requests": [
{
"path": "/health",
"status": 200,
"body": "ok"
},
{
"path": "/p/invalid.gif",
"status": 200,
"capturedBodyUtf8Base64": "R0lGODlhAQABAO+/vQAA77+977+977+9AAAAIe+/vQQBAAAAACwAAAAAAQABAAACAkQBADs=",
"representation": "Base64 of retained decoded response text encoded as UTF-8; includes originally captured U+FFFD replacement characters; not original GIF wire bytes"
}
],
"ready": true,
"processExitBeforeCleanup": null,
"taskProcessGroupStopped": true
}Baseline platform-plus-explicit actual Revoked errorsRecorded rebuilt bundle identities (empty means no emitted artifact was retained)[]Original retained input and redacted projection hashes[
{
"path": "collected/gogcli/evidence/candidate-selected-identity.log",
"sha256": "3b8224b4509d57f7b61c9dcf1e05e9d8adcb4d6b4e1f3381bec0e4ba32b3cf3a",
"projection": "candidate-selected-identity.json",
"projectionSha256": "188c27a71a33290be8e0b1296f540e65dceb315190c4d60633d7cf6f45d02820",
"redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
},
{
"path": "collected/gogcli/evidence/baseline-install.json",
"sha256": "06e94849384c54c51324aef0a483e61b7d042eca0f7617f3f1e2f226f3d9872a",
"projection": "baseline-install.json",
"projectionSha256": "0a75010f92e3f71000def46c2bdaeec917434ba1028e0c14ac71c167efc0776e",
"redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
},
{
"path": "collected/gogcli/evidence/candidate-install.json",
"sha256": "8c0049029ffb4fc8f604d2c06d52a1957a39479c6ea0f7b9fdda2ff87828a25d",
"projection": "candidate-install.json",
"projectionSha256": "2ae40e83f99e4a4b09c0007560e3e305d98bd1472c681390eefe0fe12409f55a",
"redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
},
{
"path": "collected/gogcli/evidence/candidate-checks.json",
"sha256": "38f1a1b7718ad200da65af1595299c30b28ae11b30aff2b2318f8108428601b1",
"projection": "candidate-checks.json",
"projectionSha256": "38f1a1b7718ad200da65af1595299c30b28ae11b30aff2b2318f8108428601b1",
"redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
},
{
"path": "collected/gogcli/evidence/candidate-local-worker.json",
"sha256": "08f52704205f66b7f9e9ad2f5e8404dab95da8a091f2bc47c1769062329b796d",
"projection": "candidate-local-worker.json",
"projectionSha256": "b24e94345baf75f6ce553eff0345f63030a76bf138321c8c95e5ea17315a52ab",
"redactions": "Task-root paths tokenized; one retained decoded GIF response text represented as UTF8-base64 for GitHub (not original GIF bytes); all other fields preserved"
},
{
"path": "collected/native-engine/evidence/gogcli-baseline-system-plus-explicit.log",
"sha256": "1b9735568346ee8a146a7a4a48094233c248720509a04e7a3ec38b0893eaacbf",
"projection": "gogcli-baseline-system-plus-explicit.log",
"projectionSha256": "1b9735568346ee8a146a7a4a48094233c248720509a04e7a3ec38b0893eaacbf",
"redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
},
{
"path": "collected/gogcli/evidence/rebuilt-worker-artifacts.json",
"sha256": "37517e5f3dc66819f61f5a7bb8ace1921282415f10551d2defa5c3eb0985b570",
"projection": "rebuilt-worker-artifacts.json",
"projectionSha256": "37517e5f3dc66819f61f5a7bb8ace1921282415f10551d2defa5c3eb0985b570",
"redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
},
{
"path": "collected/native-engine/evidence/results.json",
"sha256": "0c6f25ddb0abcdbc14c60f4839777f85baf043301453d6711172503fbc4b1d39",
"publicScope": "Lossless field-preserving selection of this consumer baseline32rows; exact candidate32rows in linked shared proof"
}
] |
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
Prepare 0.47.1 as a patch release for the Gmail text-direction, Calendar reauthorization, and headless Linux authentication fixes, plus dependency and certificate-security updates. Finalize the dated changelog without removing any existing bullet or contributor credit, add the missing workerd certificate-security entry from #1264, and set the matching release version. Document the supported signed-tag reuse path so publication follows the fleet signing policy while binary signing and notarization stay in Actions. Validation: changelog bullet preservation and whitespace checks passed; independent Codex review found no actionable P0–P2 findings. `make ci` passed on the AWS Crabbox lease `cbx_9acea581b206` (hydration run https://github.com/openclaw/gogcli/actions/runs/40439761515). `govulncheck ./...` passed with zero reachable vulnerabilities; the only module advisory is the unimported OpenPGP package (GO-2026-5932). All checks passed at 73d0dbb, including Darwin, Windows, minimum-Go, tracking worker, Docker, and CodeQL (CI run https://github.com/openclaw/gogcli/actions/runs/40439890816). Publication follows a successful dry run on the merge commit.
Pin local workerd to 1.20261021.1 so the development/test engine rejects the verified compromised eMudhra keys even when historical roots are supplied explicitly. Retain the existing Wrangler/Miniflare versions and package-manager owner; regenerate the lockfile through its native manager. No application trust bypass or production deployment is introduced.
Validation on native macOS ARM64 (Node 26.12.1, Bun 1.4.4 or repository-pinned pnpm/npm):
make worker-ci(lint/typecheck/dry-run/test), additional build and local health200/invalid-pixel200.44a06c31a6578f234cdf7f23219b88978c8d8d21cb8ce85795cab53614b50d64.CertDistrustedwith explicit-only historical trust;Revokedwith system-plus-explicit trust; public HTTPS and task private-CA HTTPS pass in both modes. Independent chain+exact-hostname controls 14/14 pass; six TLS key identities match verified incident denylist, including alternate/cross-sign chains. Two code-signing keys covered by exact upstream-source denylist comparison, not live code-signing execution.git diff --checkpasses.Limits: Old native macOS engine already rejects all 14 using system trust (
Revoked), but accepts14 with explicit-only historical trust; do not overstate baseline vulnerability. Full unrelated Go/macOS app not rebuilt locally. PR Docker workflow may build an unpublished image from internal/**; no host Docker. This validates source, rebuilt bundle and local engine behavior; it does not establish deployed Cloudflare/fleet delivery or other native architectures.Existing automatic effects: CI, Docker validation (internal/** trigger) and ClawSweeper dispatch on PR. Docker publication requires tag/manual source; main merge alone does not publish. Pages filters do not match. Commit through required committer helper.
Exact base
563e30a205d911f7f2bd15f4504ee950e6e98cf2; reviewed patch SHA256f1b7bd85a0da2b0074010b50600074fa1f6296e4160a72c40a460360df4e60fb. Detailed evidence is retained in the local available-fix campaignlanes/workerd-propagation-macos/gogcli/REPORT.mdandMANIFEST.json.Final tested source head
59bcfd9c0ad3dc2ad11a7371afcc5c7bcb193d7a. The committed file bytes match the reviewed and natively validated two-file proposal exactly; no post-proof source change.Inspectable native TLS evidence
The final-head proof supplement publishes this consumer's exact resolver, baseline output, install/build/local-entry receipts and artifact hashes, and links the complete same-hash candidate handshake traces with independent chain/hostname and legitimate controls. Candidate explicit-only rejects with CertDistrusted; platform-plus-explicit rejects with Revoked. Observed proof is TLS-handshake rejection before Worker fetch completion; direct remote wire-byte/credential absence and 0-RTT are not measured. No managed Cloudflare fleet delivery is claimed.
Release-note context: Local tracking-Worker workerd 1.20261021.1 rejects the disclosed compromised keys even with historical explicit roots; managed Cloudflare runtime delivery is separate. CHANGELOG.md stays release-owned under explicit maintainer campaign instruction; the supplement explains disposition of the P3 Unreleased suggestion.