Repository navigation
fix(calendar): Clear timed fields in all-day updates [AI-964] - #1349
finn-atlas wants to merge 2 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. What this changesCalendar updates explicitly clear incompatible timed or all-day fields and preserve those clears through recurrence normalization. Example: Convert a timed event using --from 2030-01-01 --to 2030-01-02 --all-day.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Blocked before merge - 1 item remains Keep open: this PR provides a focused fix for a current Calendar conversion bug, with no concrete correctness defect found. Priority: P2 Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherThe Calendar CLI turns update flags into a Google Calendar Event patch, normalizes recurrence boundaries when needed, and sends it through the Google API client. flowchart LR
A[Calendar update flags] --> B[Update plan]
B --> C[Boundary construction]
C --> D[Recurrence normalization]
D --> E[Google client serialization]
E --> F[Calendar Events Patch]
Technical reviewBest possible solution: Keep the update-specific null clears and metadata-preserving clone within the existing Calendar patch owner. Do we have a high-confidence way to reproduce the issue? Main source and the pinned serializer establish omitted incompatible fields; the linked report supplies the resulting live 400, and no target code was run during this review. Is this the best way to solve the issue? Explicit nulls repair nested PATCH semantics without replacing whole events or changing create behavior, and preserving their metadata closes the recurrence path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 31c4e14186e8. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 21, 2026, 7:06 PM ET / November 22, 2026, 00:06 UTC. |
|
The proof hold is acknowledged. I will not create or mutate a live calendar event for this PR: the originating operator explicitly prohibited calendar changes, and this repair has no authorized disposable calendar target. Available evidence is the reported real pre-fix |
Closes #1348
What Problem This Solves
A timed Google Calendar event can fail with
400 Invalid start timewhencalendar update --all-daychanges it to an all-day event. The patch sets the all-day date but leaves the existing timed fields in Google's nested event data.User Impact
Users can convert events between timed and all-day forms with
calendar updatewithout leaving incompatible start or end fields.Why This Change Was Made
Update requests now send JSON null values for the previous time representation. All-day updates clear
dateTimeandtimeZone. Timed updates cleardate.Evidence
Calendar tests pass for both conversions, recurring updates, and restoring reminder defaults.
Dry runs of timed-to-all-day updates now send
dateTime: nullandtimeZone: nullwith each all-day date, including recurring events.make cicompleted formatting and lint checks. Its full test run found two Gmail failures that also reproduce onorigin/main:TestGmailDraftsRawDirectTokenRequiresAccountTestGmailSendRawDirectTokenRequiresConcreteAccount