Skip to content

feat: offer selective voice-model removal when uninstalling Companion - #2328

Open
roboclaw-bot wants to merge 9 commits into
mainfrom
openclaw/quick-shrimp-2
Open

roboclaw-bot wants to merge 9 commits into
mainfrom
openclaw/quick-shrimp-2

Conversation

@roboclaw-bot

@roboclaw-bot roboclaw-bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

What Problem This Solves

Related: #2286

Adds opt-in Kokoro cleanup with measured previews.

Focused proof passed; landing awaits official signed-artifact acceptance.

User Impact

Keep by default; preview before consent. Other data/Gateway removal stay separate.

Why This Change Was Made

Async preview; verified deletion only; no recursion.

Evidence

Signed baseline → unsigned production identity. Upgrade, active Cancel, migration exclusion/preservation, keep and remove passed.

Before
Before

After
After

Video (cropped, 16 seconds):
https://github.com/user-attachments/assets/a31da3d2-5a5f-4e0b-8982-809bec5e3b09

Change Type

  • Bug fix
  • Feature
  • Refactor
  • Docs or instructions
  • Tests or validation
  • Security hardening
  • Chore or infrastructure

Scope

  • Tray or WinUI UX
  • Windows node capability
  • Local MCP or winnode
  • Gateway, connection, or pairing
  • Setup or onboarding
  • Permissions, privacy, or security
  • Tests, CI, or docs

Required proof pools

  • windows-clean-installer-upgrade: focused production-identity pass; unsigned candidate, not full signed-release acceptance.

Validation

Production proof: build passed; Shared 5,910 passed/29 skips; Tray 6,786 passed/0 skips; 7 custom scenarios passed/0 skips. CI Gate passed.

Real Behavior Proof

  • Environment tested: disposable hosted Windows; full installed Inno payload.
  • PR head or commit tested: d6d009dbdff909d2c2df459a0534cb410d753414.
  • Exact steps or command run: temporary proof #2345, not in this diff.
  • Evidence after fix: PNG/MP4 above; 397,397,365 bytes removed.
  • Observed result: settings/sentinel preserved; migration blocks deletion; worker exits before Cancel closes UI.
  • Screenshot or artifact links verified? Images/video inspected; public bytes verified.
  • Not verified: candidate signing/reputation, ARM64, real Store/Gateway.

Security Impact

  • New permissions or capabilities? Yes; opt-in file deletion, no elevation.
  • Secrets or tokens handling changed? No.
  • New or changed network calls? No.
  • Command or tool execution surface changed? Yes; bounded PowerShell helper.
  • Data access scope changed? Yes; pinned Kokoro files only.
  • If any answer is Yes, explain the risk and mitigation: unchecked consent, hash/handle verification, migration checks; failures retain files.

Compatibility and Migration

  • Backward compatible? Intended; signed upgrade unverified.
  • Config or environment changes? Yes; optional bounded scan/process timeouts.
  • Migration needed? No.
  • If yes, list the exact upgrade steps: N/A.

Managed publication used an upstream branch; the required fork-source workflow remains unresolved.

Review Conversations

  • I replied to or resolved every bot review conversation addressed by this PR.
  • I left unresolved only conversations that still need maintainer judgment.

Contributor credit

DonnieFi: requirements; jalehman: proof/landing authorization; RoboClaw: implementation.

Work sessions

Linked for team reference; these sessions aren’t public.

🦞 Made with OpenClaw

Worked on by

Worked on by:
- @DonnieFi

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: 73d4d23a-1d56-4b8d-91f3-1b381396c797
@clawsweeper

clawsweeper Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:feature Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. and removed clawsweeper:intake:feature Preliminary submission classification; full source review pending. labels Nov 19, 2026
@clawsweeper

clawsweeper Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codex review: blocked before merge.

What this changes

Adds an unchecked Inno uninstall choice to preview and remove verified Kokoro downloads while preserving unrelated files.

Example: Uninstall Companion with the English and Chinese Kokoro pack downloaded.

  • Before: The two model files totaling 397,397,365 bytes remain without an uninstall cleanup choice.
  • After: The user can preview their paths and measured sizes, then explicitly select removal or keep them.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) Useful implementation with shipped-entry-point evidence and no actionable code finding; it deliberately addresses only part of the linked issue.
Proof confidence 🐚 platinum hermit (4/6) ✨ media proof bonus Sufficient (screenshot): Current-head screenshots directly show the installed Inno preview; linked acceptance records upgrade, active cancellation, migration preservation, keep, and removal on disposable Windows x64 with an unsigned production-identity candidate. The linked run succeeded; storage-download and video-decoding restrictions limited independent inspection of its remaining artifacts.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Feature · Worth it: Yes · Fix scope: Partial
User problem: Users uninstalling Companion cannot choose to reclaim retained Kokoro downloads or see their measured size in the uninstall flow.
Reason: The maintainer-authored direction addresses a documented disk-space problem with explicit consent and a narrow preservation boundary.

Merge readiness

⛔ Blocked before merge - 1 item remains

Keep open: this maintainer-authored PR provides useful uninstall functionality absent from current main, with no concrete introduced defect found.

Priority: P2
Reviewed head: d6d009dbdff909d2c2df459a0534cb410d753414

Before merge

  • Await maintainer action - Schedule and complete the required installer upgrade/uninstall acceptance with exact signed candidate artifacts before landing.

Findings

None.

Tests

  • Missing end-to-end proof: The maintainer-scheduled installer pool still needs acceptance using exact signed candidate artifacts.
Agent review details

How this fits together

The Inno uninstaller collects consent, checks existing migration safeguards, and invokes a bounded PowerShell worker that verifies catalog files and returns a cleanup report.

flowchart TD
  A[Inno uninstall dialog] --> B[Consent and migration checks]
  A --> C[PowerShell supervisor]
  B --> C
  C --> D[File verification worker]
  E[Shared Kokoro catalog] --> D
  D --> F[Selected local model files]
  C --> G[Completion report]
Loading

Technical review

Best possible solution:

Land the bounded opt-in Kokoro cleanup while preserving default retention, existing migration safeguards, and separate tracking for the broader uninstall request.

Do we have a high-confidence way to reproduce the issue?

The reported retained files match the existing Kokoro catalog and storage layout; current main lacks this uninstall choice, and no target code was executed during this review.

Is this the best way to solve the issue?

The approach fits the authorized feature: reuse the existing migration admission checks, share one pinned catalog, and keep uninstall deletion narrower than the app's recursive pack-deletion API.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 794f530aa933.

Provenance checked

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

  • Introduced change and current-main comparison: The pinned introduced diff adds the model-choice flow; current main retains the original installer and Kokoro catalog behavior on these paths. (installer.iss:763, d6d009dbdff9)
  • Deletion boundary: Removal uses the consented catalog mask, rechecks content hashes, rejects redirected and hard-linked files, and deletes through the verified handle. (src/OpenClaw.Shared/Audio/KokoroUninstallFiles.cs:80, d6d009dbdff9)
  • Reported need and scope: DonnieFi identifies the exact retained Kokoro files in [Feature]: Uninstall should offer to remove downloaded models and stale app data #2286; this PR appropriately uses Related because stale app data, temporary files, and Gateway wording remain outside its scope.
  • Supplied runtime evidence: Inspected both downloaded screenshots, including the unchecked 397,397,365-byte preview. chore: DO NOT MERGE production uninstall acceptance for PR2328 #2345 records current-head installed-caller acceptance, and its linked run completed successfully. Artifact download was blocked at the storage redirect; video preparation failed with ffprobe ENOENT and browser fallback returned Cache miss. These are review-environment limitations. (d6d009dbdff9)
  • Required signed-artifact acceptance: The applicable installer pool requires exact official signed artifacts and maintainer scheduling; the supplied acceptance explicitly used an unsigned candidate. (.github/proof-pools.json:265, d6d009dbdff9)
  • Policy, history, and review limits: Read root and documentation AGENTS.md files and relevant skills; no additional changed-path ancestor guidance or maintainer-notes directory exists. Scoped history and blame identify shared ownership. Some historical object reads failed with lazy fetching disabled. No builds, tests, target helper, or second reviewer ran; final git status was clean. (AGENTS.md:14, d6d009dbdff9)

Likely related people:

  • Pedro Larroy: Raw commit 2a33672 adds src/OpenClaw.Shared/Audio/KokoroModelManager.cs:34 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 2a33672baedb; files: src/OpenClaw.Shared/Audio/KokoroModelManager.cs)
  • Natalie Aguinaldo: Raw commit 5a59535 adds installer.iss:203 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 5a59535216ee; files: installer.iss)
  • Ranjesh: Raw commit 8af4b70 adds installer.iss:233 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 8af4b70360a9; files: installer.iss)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Review metrics

Metric Value Why it matters
Production and test delta Production +693/-10 lines; tests +514; documentation +4. Growth supports the responsive installer dialog, isolated helper, shared catalog, and distinct native-file and process-boundary coverage.

Labels

Label changes:

  • add proof: sufficient: Contributor real behavior proof is sufficient.
  • add proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • add status: ⏳ waiting on maintainer: Only explicit maintainer approvals or decisions remain; merge is still blocked.
  • remove status: 👀 ready for maintainer look: Current PR status label is status: ⏳ waiting on maintainer.
  • remove rating: 🦪 silver shellfish: Current PR rating is rating: 🦐 gold shrimp, so this older rating label is no longer current.

Label justifications:

  • P2: This adds an ordinary uninstall path for reclaiming substantial downloaded-model space without changing default retention.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • status: ⏳ waiting on maintainer: Only explicit maintainer approvals or decisions remain; merge is still blocked.
  • proof: sufficient: Contributor real behavior proof is sufficient.
  • proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (3 earlier review cycles)
  • reviewed 2026-11-19T00:29:21.479Z sha 34e9c52 :: needs changes before merge. :: [P1] [P1] Pass the required arguments to CreateCustomForm | [P2] [P2] Match hash nullability in the catalog comparison | [P2] [P2] Keep the dialog interactive while the preview helper runs
  • reviewed 2026-11-20T01:04:48.540Z sha eb9e7fa :: needs maintainer review before merge. :: none
  • reviewed 2026-11-20T11:46:29.298Z sha 85c5b34 :: needs maintainer review before merge. :: none

Reviewed November 20, 2026, 9:13 PM ET / November 21, 2026, 02:13 UTC (Revision 4).

Copy link
Copy Markdown
Contributor

Additional baseline evidence from @DonnieFi’s Windows 11 Petty run (Companion 2026.11.3): after uninstall from Windows Settings, %APPDATA%\OpenClawTray\models still contained two files totaling 397,397,365 bytes (~379 MiB). The app and native Gateway were removed, but uninstall first required ending the still-running Companion process. This is the original observation behind #2286, not an independent reproduction or a test of this PR.

The redacted Focus Week capture includes a report, timeline, commands and logs (private evidence run 96258ccb-29f2-41f3-b799-1f002bc2e5cb); its completion inventory and object metadata are present in R2. The screenshot in that capture shows the earlier blocked uninstall, not this PR’s model dialog. No reboot/logon test was performed in that run.

This supports the user need; it does not establish current-head behavior, resolve the compilation or cancellation findings, or provide signed-installer proof. A later read-only check found no running OpenClaw process, service, installed Appx package or uninstall entry on Petty; the two model files and an inactive scheduled task remain. Petty may be suitable for a new Windows validation pass once a buildable revision and appropriate test installer are available.

roboclaw-bot and others added 2 commits November 20, 2026 00:22
Worked on by:
- @DonnieFi

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: 2ec673e9-a7a4-4a0d-898c-50cd68c59447
Worked on by:
- @DonnieFi

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: 49448427-c9c4-471b-884d-52cf8d17167b
@roboclaw-bot

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Nov 20, 2026
roboclaw-bot and others added 5 commits November 20, 2026 08:17
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: 66d9096b-d3fe-4c66-b2dd-9fde3bfa10f1
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: a09a0987-df78-4fe0-8ee4-cbfeee98d3ef
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: 4a214e0c-e5d3-452c-994e-e9056e0aa345
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: ee2d8088-cf37-4c29-9335-afe975fb1cad
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: c0cd2cec-53b7-4729-a978-18e339f4b8c8
@roboclaw-bot

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. labels Nov 20, 2026
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: 5f887b48-f20a-4bdf-bb7e-d519400e5c1d
@jalehman
jalehman marked this pull request as ready for review November 20, 2026 18:46
@roboclaw-bot

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot removed the status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. label Nov 21, 2026
@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on maintainer Only explicit maintainer approvals or decisions remain; merge is still blocked. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Nov 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. proof: sufficient Contributor real behavior proof is sufficient. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on maintainer Only explicit maintainer approvals or decisions remain; merge is still blocked.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants