Repository navigation
feat: offer selective voice-model removal when uninstalling Companion - #2328
roboclaw-bot wants to merge 9 commits into
Conversation
Worked on by: - @DonnieFi Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com> OpenClaw-Publication: 73d4d23a-1d56-4b8d-91f3-1b381396c797
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. What this changesAdds an unchecked Inno uninstall choice to preview and remove verified Kokoro downloads while preserving unrelated files. Example: Uninstall Companion with the English and Chinese Kokoro pack downloaded.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Partial Merge readiness⛔ Blocked before merge - 1 item remains Keep open: this maintainer-authored PR provides useful uninstall functionality absent from current main, with no concrete introduced defect found. Priority: P2 Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherThe Inno uninstaller collects consent, checks existing migration safeguards, and invokes a bounded PowerShell worker that verifies catalog files and returns a cleanup report. flowchart TD
A[Inno uninstall dialog] --> B[Consent and migration checks]
A --> C[PowerShell supervisor]
B --> C
C --> D[File verification worker]
E[Shared Kokoro catalog] --> D
D --> F[Selected local model files]
C --> G[Completion report]
Technical reviewBest possible solution: Land the bounded opt-in Kokoro cleanup while preserving default retention, existing migration safeguards, and separate tracking for the broader uninstall request. Do we have a high-confidence way to reproduce the issue? The reported retained files match the existing Kokoro catalog and storage layout; current main lacks this uninstall choice, and no target code was executed during this review. Is this the best way to solve the issue? The approach fits the authorized feature: reuse the existing migration admission checks, share one pinned catalog, and keep uninstall deletion narrower than the app's recursive pack-deletion API. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 794f530aa933. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (3 earlier review cycles)
Reviewed November 20, 2026, 9:13 PM ET / November 21, 2026, 02:13 UTC (Revision 4). |
|
Additional baseline evidence from @DonnieFi’s Windows 11 Petty run (Companion 2026.11.3): after uninstall from Windows Settings, The redacted Focus Week capture includes a report, timeline, commands and logs (private evidence run This supports the user need; it does not establish current-head behavior, resolve the compilation or cancellation findings, or provide signed-installer proof. A later read-only check found no running OpenClaw process, service, installed Appx package or uninstall entry on Petty; the two model files and an inactive scheduled task remain. Petty may be suitable for a new Windows validation pass once a buildable revision and appropriate test installer are available. |
Worked on by: - @DonnieFi Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com> OpenClaw-Publication: 2ec673e9-a7a4-4a0d-898c-50cd68c59447
Worked on by: - @DonnieFi Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com> OpenClaw-Publication: 49448427-c9c4-471b-884d-52cf8d17167b
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
What Problem This Solves
Related: #2286
Adds opt-in Kokoro cleanup with measured previews.
Focused proof passed; landing awaits official signed-artifact acceptance.
User Impact
Keep by default; preview before consent. Other data/Gateway removal stay separate.
Why This Change Was Made
Async preview; verified deletion only; no recursion.
Evidence
Signed baseline → unsigned production identity. Upgrade, active Cancel, migration exclusion/preservation, keep and remove passed.
Before

After

Video (cropped, 16 seconds):
https://github.com/user-attachments/assets/a31da3d2-5a5f-4e0b-8982-809bec5e3b09
Change Type
Scope
winnodeRequired proof pools
windows-clean-installer-upgrade: focused production-identity pass; unsigned candidate, not full signed-release acceptance.Validation
Production proof: build passed; Shared 5,910 passed/29 skips; Tray 6,786 passed/0 skips; 7 custom scenarios passed/0 skips. CI Gate passed.
Real Behavior Proof
d6d009dbdff909d2c2df459a0534cb410d753414.Security Impact
Yes, explain the risk and mitigation: unchecked consent, hash/handle verification, migration checks; failures retain files.Compatibility and Migration
Managed publication used an upstream branch; the required fork-source workflow remains unresolved.
Review Conversations
Contributor credit
DonnieFi: requirements; jalehman: proof/landing authorization; RoboClaw: implementation.
Work sessions
Linked for team reference; these sessions aren’t public.
Discussion, implementation and verification
Capture implementation
Production acceptance
🦞 Made with OpenClaw
Worked on by