Repository navigation
chore: DO NOT MERGE production uninstall acceptance for PR2328 - #2345
roboclaw-bot wants to merge 12 commits into
Conversation
Worked on by: - @DonnieFi Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com> OpenClaw-Publication: 73d4d23a-1d56-4b8d-91f3-1b381396c797
Worked on by: - @DonnieFi Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com> OpenClaw-Publication: 2ec673e9-a7a4-4a0d-898c-50cd68c59447
Worked on by: - @DonnieFi Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com> OpenClaw-Publication: 49448427-c9c4-471b-884d-52cf8d17167b
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR adds disposable Windows acceptance automation for production-identity upgrade, uninstall cancellation, migration preservation, and selective voice-model removal. Example: Upgrade signed Companion v2026.11.3 with 397,397,365 bytes of Kokoro downloads.
Review scores
ProductKind: Test only · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open as an explicitly temporary, do-not-merge draft supporting the linked uninstall feature; source review found no definite introduced defect. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherA GitHub-hosted Windows workflow builds a pinned product candidate and passes its installer plus a verified released installer to a process-bound UI automation script, which produces scenario receipts, inventories, screenshots, and recordings. flowchart TD
A[Hosted Windows workflow] --> B[Pinned candidate build]
A --> C[Verified released installer]
B --> D[Disposable acceptance script]
C --> D
D --> E[Installed Inno uninstaller]
E --> F[Model and migration helpers]
D --> G[Receipts and media artifacts]
Technical reviewBest possible solution: Keep this infrastructure temporary and use its inspected acceptance artifacts to inform the selective model-uninstall PR. Do we have a high-confidence way to reproduce the issue? This PR supplies validation infrastructure rather than a product bug fix; its scenario paths were inspected without executing target code. Is this the best way to solve the issue? The gap is production-identity acceptance, the invariant is preserving unrelated state and Gateway ownership, and the smallest complete approach exercises the existing installer, migration codec, and model helpers through one disposable capture script. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 794f530aa933. TestingProof path: none. SecurityNone. EvidenceWhat I checked:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 20, 2026, 8:29 PM ET / November 21, 2026, 01:29 UTC. |
Contributor credit: @DonnieFi reported the issue; @jalehman authorized this temporary proof pass.
Work sessions
Linked for team reference; these sessions aren’t public.
What Problem This Solves
DO NOT MERGE. Production acceptance for #2328 (feat: offer selective voice-model removal when uninstalling Companion).
User Impact
No product change. Full production identity candidate is unsigned; signing/reputation remain unverified.
Why This Change Was Made
Test the installed caller on fresh disposable Windows, with real models and synthetic settings/migration records. No Gateway/WSL mutation.
Evidence
Seven scenarios passed. Run and verified artifact: upgrade, active Cancel, lock exclusion, completed/uncertain migration preservation, keep, remove.
Change Type
Scope
winnodeRequired proof pools
windows-clean-installer-upgrade: focused unsigned-candidate production-identity proof, not full signed acceptance.windows-winui-interactive: installed Inno choices/cancellation.Validation
Full build passed. Shared: 5,910 passed, 29 ordinary skips; Tray: 6,786 passed, 0 skipped. Seven custom scenarios passed, none skipped. ClawSweeper found no defects at
4ae9209; later harness fix releases its lock before hashing. Failed attempt44849030065is preserved. Do not merge.Real Behavior Proof
d6d009dbdff909d2c2df459a0534cb410d753414, tooling10bb2a5b2b500815e1aab1b9cf0d1d7f5e375d87.capture-inno-production-uninstall.ps1via Windows PowerShell 5.1 STA.09c928177deb4c0803e0d0ad52176349e5a209f94d9b7fb9258050081fd407b1; 76 manifest entries verified.Security Impact
Yes, explain the risk and mitigation: fresh-host/process-identity guards; no silent uninstall; Gateway always No; no Store/WSL mutation.Compatibility and Migration
Review Conversations
Worked on by