Skip to content

chore: DO NOT MERGE production uninstall acceptance for PR2328 - #2345

Draft
roboclaw-bot wants to merge 12 commits into
mainfrom
openclaw/pr2328-production-proof
Draft

roboclaw-bot wants to merge 12 commits into
mainfrom
openclaw/pr2328-production-proof

Conversation

@roboclaw-bot

@roboclaw-bot roboclaw-bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Contributor credit: @DonnieFi reported the issue; @jalehman authorized this temporary proof pass.

Work sessions

Linked for team reference; these sessions aren’t public.

What Problem This Solves

DO NOT MERGE. Production acceptance for #2328 (feat: offer selective voice-model removal when uninstalling Companion).

User Impact

No product change. Full production identity candidate is unsigned; signing/reputation remain unverified.

Why This Change Was Made

Test the installed caller on fresh disposable Windows, with real models and synthetic settings/migration records. No Gateway/WSL mutation.

Evidence

Seven scenarios passed. Run and verified artifact: upgrade, active Cancel, lock exclusion, completed/uncertain migration preservation, keep, remove.

Change Type

  • Bug fix
  • Feature
  • Refactor
  • Docs or instructions
  • Tests or validation
  • Security hardening
  • Chore or infrastructure

Scope

  • Tray or WinUI UX
  • Windows node capability
  • Local MCP or winnode
  • Gateway, connection, or pairing
  • Setup or onboarding
  • Permissions, privacy, or security
  • Tests, CI, or docs

Required proof pools

  • windows-clean-installer-upgrade: focused unsigned-candidate production-identity proof, not full signed acceptance.
  • windows-winui-interactive: installed Inno choices/cancellation.

Validation

Full build passed. Shared: 5,910 passed, 29 ordinary skips; Tray: 6,786 passed, 0 skipped. Seven custom scenarios passed, none skipped. ClawSweeper found no defects at 4ae9209; later harness fix releases its lock before hashing. Failed attempt 44849030065 is preserved. Do not merge.

Real Behavior Proof

  • Environment tested: disposable hosted Windows 10.0.26100 x64.
  • PR head or commit tested: pinned candidate d6d009dbdff909d2c2df459a0534cb410d753414, tooling 10bb2a5b2b500815e1aab1b9cf0d1d7f5e375d87.
  • Exact steps or command run: capture-inno-production-uninstall.ps1 via Windows PowerShell 5.1 STA.
  • Evidence after fix: artifact SHA256 09c928177deb4c0803e0d0ad52176349e5a209f94d9b7fb9258050081fd407b1; 76 manifest entries verified.
  • Observed result: 397,397,365 selected bytes removed; settings/sentinel hashes unchanged. Worker exit and cancelled receipt precede dialog dismissal.
  • Screenshot or artifact links verified? Yes. Screenshots and six decoded removal-video frames inspected.
  • Not verified or blocked: candidate signing/reputation, ARM64, real Store/Gateway excluded.

Security Impact

  • New permissions or capabilities? No. Read-only workflow token.
  • Secrets or tokens handling changed? No.
  • New or changed network calls? Yes: public baseline/model downloads.
  • Command or tool execution surface changed? Yes: temporary hosted proof.
  • Data access scope changed? Yes: fresh-host synthetic production paths only.
  • If any answer is Yes, explain the risk and mitigation: fresh-host/process-identity guards; no silent uninstall; Gateway always No; no Store/WSL mutation.

Compatibility and Migration

  • Backward compatible? Yes. No production edits.
  • Config or environment changes? No.
  • Migration needed? No.
  • If yes, list the exact upgrade steps: N/A.

Review Conversations

  • I replied to or resolved every bot review conversation addressed by this PR.
  • I left unresolved only conversations that still need maintainer judgment.

Worked on by

roboclaw-bot and others added 10 commits November 19, 2026 00:11
Worked on by:
- @DonnieFi

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: 73d4d23a-1d56-4b8d-91f3-1b381396c797
Worked on by:
- @DonnieFi

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: 2ec673e9-a7a4-4a0d-898c-50cd68c59447
Worked on by:
- @DonnieFi

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: 49448427-c9c4-471b-884d-52cf8d17167b
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: 66d9096b-d3fe-4c66-b2dd-9fde3bfa10f1
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: a09a0987-df78-4fe0-8ee4-cbfeee98d3ef
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: 4a214e0c-e5d3-452c-994e-e9056e0aa345
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: ee2d8088-cf37-4c29-9335-afe975fb1cad
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: c0cd2cec-53b7-4729-a978-18e339f4b8c8
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: 5f887b48-f20a-4bdf-bb7e-d519400e5c1d
Worked on by:
- @jalehman
- @DonnieFi

Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: 61d3397c-8729-464c-a7af-2842650d26f4
@clawsweeper

clawsweeper Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

Worked on by:
- @jalehman
- @DonnieFi

Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: d1794bc6-86b7-47b8-8b91-3181d18b03d9
@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Nov 21, 2026
@clawsweeper

clawsweeper Bot commented Nov 21, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR adds disposable Windows acceptance automation for production-identity upgrade, uninstall cancellation, migration preservation, and selective voice-model removal.

Example: Upgrade signed Companion v2026.11.3 with 397,397,365 bytes of Kokoro downloads.

  • Before: Earlier capture used a separate Dev installation and did not establish production upgrade or migration admission.
  • After: The proposed workflow upgrades the production installation and checks cancellation, migration preservation, keep/remove choices, and unchanged settings.

Review scores

Measure Result What it means
Overall readiness 🦪 silver shellfish (2/6) The acceptance design is coherent and source review found no actionable defect, but execution of the new scenario harness remains unverified.
Proof confidence 🦪 silver shellfish (2/6) This automation-only PR needs no separate shipped-entry-point proof; its hosted candidate build and Shared/Tray validation passed, while installed acceptance scenarios have not yet run, and the historical Dev screenshots establish no result for this new harness.
Patch quality 🦐 gold shrimp (3/6) No actionable review findings were identified.

Product

Kind: Test only · Worth it: Yes · Fix scope: Complete
User problem: Maintainers lack production-identity upgrade and migration-admission acceptance for selective model removal.
Reason: The maintainer-authorized temporary pass targets distinct gaps in the earlier Dev capture while keeping product implementation in the linked PR.

Merge readiness

✅ Ready for maintainer review

Keep this PR open as an explicitly temporary, do-not-merge draft supporting the linked uninstall feature; source review found no definite introduced defect.

Priority: P3
Reviewed head: 4ae9209aa6c7dcb82057552da1f32fcdbea1a930

Before merge

None.

Findings

None.

Agent review details

How this fits together

A GitHub-hosted Windows workflow builds a pinned product candidate and passes its installer plus a verified released installer to a process-bound UI automation script, which produces scenario receipts, inventories, screenshots, and recordings.

flowchart TD
  A[Hosted Windows workflow] --> B[Pinned candidate build]
  A --> C[Verified released installer]
  B --> D[Disposable acceptance script]
  C --> D
  D --> E[Installed Inno uninstaller]
  E --> F[Model and migration helpers]
  D --> G[Receipts and media artifacts]
Loading

Technical review

Best possible solution:

Keep this infrastructure temporary and use its inspected acceptance artifacts to inform the selective model-uninstall PR.

Do we have a high-confidence way to reproduce the issue?

This PR supplies validation infrastructure rather than a product bug fix; its scenario paths were inspected without executing target code.

Is this the best way to solve the issue?

The gap is production-identity acceptance, the invariant is preserving unrelated state and Gateway ownership, and the smallest complete approach exercises the existing installer, migration codec, and model helpers through one disposable capture script.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 794f530aa933.

Testing

Proof path: none.

Security

None.

Evidence

What I checked:

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P3: Temporary acceptance tooling changes no shipped product behavior and is explicitly held from merge.
  • add rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🦐 gold shrimp.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: Temporary acceptance tooling changes no shipped product behavior and is explicitly held from merge.
  • rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🦐 gold shrimp.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 20, 2026, 8:29 PM ET / November 21, 2026, 01:29 UTC.

Worked on by:
- @jalehman
- @DonnieFi

Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: 32641049-fd98-4faa-9995-63d31a605480

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant