Repository navigation
openshift-hyperfleet: onboard five repositories to Prow and require the tide context on repositories without jobs - #86872
Merged
openshift-merge-bot[bot] merged 1 commit intoOct 13, 2026
Conversation
…he tide context on repositories without jobs Adds Prow plugin and Tide configuration for .github, coderabbit, hyperfleet-hooks, hyperfleet-release and renovate-config, copied from hyperfleet-claude-plugins, so every active openshift-hyperfleet repository is governed by OWNERS, approve, lgtm, blunderbuss, owners-label and verify-owners. Adds branch protection requiring the tide status context on the eight repositories that have no CI jobs (the five above plus hyperfleet-api-spec, hyperfleet-api-spec-template and hyperfleet-claude-plugins). Without a required context a PR there can be merged with the GitHub button, bypassing Tide and the OWNERS approval. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughAdds Prow plugin settings and branch protection for OpenShift Hyperfleet repositories. The configurations also add Tide queries for repositories with specified required and excluded labels. ChangesHyperfleet repository Prow setup
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Stable And Deterministic Test Names | |
The pull request changes only Prow YAML configuration files. The authoritative diff contains no Ginkgo test declarations or test titles, so it introduces no unstable or overly specific test names. |
| Test Structure And Quality | |
The pull request changes only 5 _pluginconfig.yaml files and 8 _prowconfig.yaml files. The authoritative diff contains no Ginkgo test files or Ginkgo constructs such as It, BeforeEach, `AfterE… |
| Microshift Test Compatibility | |
The pull request changes only Prow YAML configuration files under core-services/prow/02_config/openshift-hyperfleet. The authoritative diff contains no new Ginkgo tests or test code, so the MicroShift… |
| Single Node Openshift (Sno) Test Compatibility | |
The pull request changes only Prow YAML configuration files. The authoritative diff adds or updates branch-protection, Tide, plugin, and repository settings; it adds no Ginkgo tests or test code. Ther… |
| Topology-Aware Scheduling Compatibility | |
The pull request changes only 13 Prow YAML configuration files. The diff adds plugin settings, Tide queries, and required tide branch-protection contexts. It does not add or modify deployment manife… |
| Ote Binary Stdout Contract | |
PASS: The pull request changes only Prow YAML configuration files. It does not change an OTE binary, Go source, suite setup, or any process-level code that can write to stdout. The OTE Binary Stdout C… |
| Ipv6 And Disconnected Network Test Compatibility | |
The pull request changes only Prow YAML configuration files. The diff adds no Ginkgo tests or test code, and it introduces no IPv4-specific test assumptions or external connectivity requirements for t… |
| No-Weak-Crypto | |
The pull request changes only 13 ASCII YAML configuration files under core-services/prow/02_config/openshift-hyperfleet. The diff adds Prow plugin, Tide, and branch-protection settings. It contains … |
| Container-Privileges | |
PASS: The PR changes only 13 Prow YAML configuration files. The diff contains no container or Kubernetes manifest fields for privileged mode, host namespaces, SYS_ADMIN, root execution, or allowPrivil… |
| No-Sensitive-Data-In-Logs | |
The PR adds only Prow YAML for approvals, plugins, branch protection, and Tide queries. It adds no logging configuration or log statements, and the changed files contain no passwords, tokens, keys, PI… |
| Description Check | |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly summarizes the main changes: onboarding five repositories to Prow and requiring the Tide status context for repositories without jobs. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
Comment @coderabbitai help to get the list of available commands.
openshift-ci
Bot
added
the
approved
This was referenced Oct 12, 2026
Merged
openshift-merge-bot
Bot
added
the
rehearsals-ack
Contributor
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
This was referenced Oct 12, 2026
Merged
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, rafabene The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@ciaranRoche: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
@ciaranRoche: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot Bot
added a commit
to openshift-hyperfleet/hyperfleet-adapter
that referenced
this pull request
Oct 13, 2026
## What changed Replaces the flat list of approvers and reviewers with area owners from the ownership document: https://github.com/openshift-hyperfleet/architecture/blob/main/hyperfleet/docs/owners.md (in review in openshift-hyperfleet/architecture#232 until it merges). - OWNERS_ALIASES holds the names, OWNERS files reference aliases and carry area labels - a merge now needs an approver for every touched path - Blunderbuss requests reviewers from the area's pool ## Why Today every repository lists the same seventeen people as approvers and reviewers, so review requests route at random and any one of them can merge anything alone. Named areas put the request in front of the people who know the code and make an approver accountable for what merges. **The same criteria were applied to everyone at launch, using the last three sprints. Reviewer and approver status follows the criteria in the ownership document and nothing else.** The path to reviewer and approver is written there. Generated from hyperfleet/docs/owners.yaml in the architecture repository. Changes to ownership are a PR to that file, then a regenerated OWNERS here. Tracked in https://redhat.atlassian.net/browse/HYPERFLEET-1762 ## Merge order This is one of the nineteen per-repository OWNERS PRs, step 5 of the repository ownership rollout. It merges after the ownership document and the Prow onboarding PR, and only when the hold is lifted. The team session that announces the model has already happened. 1. openshift-hyperfleet/architecture#232, ownership document and generator. 2. openshift-hyperfleet/hyperfleet-hooks#17, commitlint validates the PR title only, then the `v0.3.0` tag. 3. openshift/release#86872, Prow onboarding and the `tide` context. Independent of 1 and 2. 4. Team session. Done, held with the team the week of 5 October. 5. **This PR.** The nineteen per-repository OWNERS PRs, after 1 and 3, when the hold is lifted: - openshift-hyperfleet/architecture#233 - openshift-hyperfleet/coderabbit#5 - **#331 (this PR)** - openshift-hyperfleet/hyperfleet-api#398 - openshift-hyperfleet/hyperfleet-api-spec#68 - openshift-hyperfleet/hyperfleet-api-spec-template#14 - openshift-hyperfleet/hyperfleet-applier#58 - openshift-hyperfleet/hyperfleet-broker#29 - openshift-hyperfleet/hyperfleet-claude-plugins#100 - openshift-hyperfleet/hyperfleet-credential-provider#15 - openshift-hyperfleet/hyperfleet-e2e#164 - openshift-hyperfleet/hyperfleet-hooks#18 - openshift-hyperfleet/hyperfleet-infra#108 - openshift-hyperfleet/hyperfleet-logger#6 - openshift-hyperfleet/hyperfleet-operator#129 - openshift-hyperfleet/hyperfleet-release#13 - openshift-hyperfleet/renovate-config#5 - openshift-hyperfleet/hyperfleet-sentinel#280 - openshift-hyperfleet/.github#1 6. openshift/release#86873, squash on merge and the commitlint pin bump, after 2. 7. openshift-hyperfleet/hyperfleet-claude-plugins#101, open-PRs digest by area, any time after 5. /hold
openshift-merge-bot Bot
pushed a commit
to openshift-hyperfleet/hyperfleet-claude-plugins
that referenced
this pull request
Oct 14, 2026
…quested reviewers (#101) ## What changed - The open-PRs digest groups PRs by their `area/*` label (first area as the group, others inline, "No area" last) and shows, per PR, the requested reviewers and business days since the request. A pending request older than one business day on a non-draft PR is flagged. Risk scoring, tiers and the Slack message shape are unchanged. - `collect-data.sh` reads `review_requested` events from the issue timeline so the request time is real, with PR `createdAt` as the fallback. - `prioritization-algorithm.md` and `output-format.md` replace "review requests are ignored because reviewers are auto-assigned" with the new rule: requests come from the area's OWNERS pool and are the reviewer of record. - `references/github-repos.md` is the current nineteen repositories (archived and out-of-scope ones removed, `hyperfleet-api-spec-template` added). - `bugs-triage/references/owners.csv` aligned with the ownership areas. - `CONTRIBUTING.md` and `AGENTS.md`: plugin OWNERS files reference aliases from the root `OWNERS_ALIASES` and are generated from the ownership document in the architecture repository. - `hyperfleet-work-triage` bumped to 0.4.0. ## Why Prow now labels PRs by area and requests reviewers from the area's OWNERS pool. The digest is what tells an approver every morning that a PR is waiting on them, so it has to show the area and the reviewer of record rather than ignoring requests. ## How to test ```text bash hyperfleet-work-triage/skills/open-prs/scripts/tests/run-tests.sh ``` 96 tests pass. A live run of `collect-data.sh --repo hyperfleet-adapter` returned real request timestamps from the timeline for adapter#330. Tracked in https://redhat.atlassian.net/browse/HYPERFLEET-1762 ## Merge order This is step 7 of the HyperFleet repository ownership rollout. It can merge any time after the area labels exist (they do), and is most useful once the OWNERS PRs (step 5) have merged. 1. openshift-hyperfleet/architecture#232, ownership document and generator. 2. openshift-hyperfleet/hyperfleet-hooks#17, commitlint validates the PR title only, then the `v0.3.0` tag. 3. openshift/release#86872, Prow onboarding and the `tide` context. Independent of 1 and 2. 4. Team session. Done, held with the team the week of 5 October. 5. The nineteen per-repository OWNERS PRs, after 1 and 3, when the hold is lifted: - openshift-hyperfleet/architecture#233 - openshift-hyperfleet/coderabbit#5 - openshift-hyperfleet/hyperfleet-adapter#331 - openshift-hyperfleet/hyperfleet-api#398 - openshift-hyperfleet/hyperfleet-api-spec#68 - openshift-hyperfleet/hyperfleet-api-spec-template#14 - openshift-hyperfleet/hyperfleet-applier#58 - openshift-hyperfleet/hyperfleet-broker#29 - #100 - openshift-hyperfleet/hyperfleet-credential-provider#15 - openshift-hyperfleet/hyperfleet-e2e#164 - openshift-hyperfleet/hyperfleet-hooks#18 - openshift-hyperfleet/hyperfleet-infra#108 - openshift-hyperfleet/hyperfleet-logger#6 - openshift-hyperfleet/hyperfleet-operator#129 - openshift-hyperfleet/hyperfleet-release#13 - openshift-hyperfleet/renovate-config#5 - openshift-hyperfleet/hyperfleet-sentinel#280 - openshift-hyperfleet/.github#1 6. openshift/release#86873, squash on merge and the commitlint pin bump, after 2. 7. **This PR.** #101, open-PRs digest by area, any time after 5. --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
oharan2
pushed a commit
to oharan2/release
that referenced
this pull request
Oct 19, 2026
…he tide context on repositories without jobs (openshift#86872) Adds Prow plugin and Tide configuration for .github, coderabbit, hyperfleet-hooks, hyperfleet-release and renovate-config, copied from hyperfleet-claude-plugins, so every active openshift-hyperfleet repository is governed by OWNERS, approve, lgtm, blunderbuss, owners-label and verify-owners. Adds branch protection requiring the tide status context on the eight repositories that have no CI jobs (the five above plus hyperfleet-api-spec, hyperfleet-api-spec-template and hyperfleet-claude-plugins). Without a required context a PR there can be merged with the GitHub button, bypassing Tide and the OWNERS approval. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
openshift-hyperfleetrepositories that were not governed by Prow:.github,coderabbit,hyperfleet-hooks,hyperfleet-release,renovate-config. Plugin and Tide config copied fromhyperfleet-claude-plugins(approve withlgtm_acts_as_approveandrequire_self_approval, lgtm withreview_acts_as_lgtm, blunderbuss, owners-label, verify-owners, same Tide query).branch-protectionrequiring thetidestatus context onmainfor the eightopenshift-hyperfleetrepositories that have no CI jobs: the five above plushyperfleet-api-spec,hyperfleet-api-spec-template,hyperfleet-claude-plugins.Why
The team is moving to area-based
OWNERSfiles where a merge needs an approver for every touched path. That only holds if Tide is the only way to merge. On repositories with no jobs nothing is required by branch protection today, so a PR can be merged with the GitHub button and skip the OWNERS approval. Requiring thetidecontext closes that. The five new repositories get the same model as the rest of the org.Notes for review
make prow-configwas run; the determinizer made no further changes.make checkconfigcould not run on my machine (podman cannot stat the mounted config directory), so the checkconfig presubmit here is the validation.openshift-ciGitHub app is installed at the org level, so the five repositories should receive events once this merges. If a repository-level install is needed for any of them, say so and I will arrange it.OWNERSfiles are added under the new directories; the auto-owners sync will generate them from each repository's rootOWNERSas it does for the other hyperfleet repositories.Tracked in https://redhat.atlassian.net/browse/HYPERFLEET-1762
Merge order
This is step 3 of the HyperFleet repository ownership rollout. It is independent of steps 1 and 2 and can merge any time. The team session (step 4) has already happened, so the OWNERS PRs wait only on step 1 and this PR. The per-repository
OWNERSPRs (step 5) in the five new repositories rely on it being in place.v0.3.0tag.tidecontext. Independent of 1 and 2.Summary by CodeRabbit
openshift-hyperfleetrepositories:.github,coderabbit,hyperfleet-hooks,hyperfleet-release, andrenovate-config. The settings enable approval and LGTM behavior, repository plugins, and trusted triggers.mainin those five repositories and inhyperfleet-api-spec,hyperfleet-api-spec-template, andhyperfleet-claude-plugins. The requiredtidestatus context helps prevent merges outside Tide.