Repository navigation
Streamline orchestrator tests (#497, slice 1) - #567
Merged
Merged
Conversation
…same-path cases, shared setup helpers (#497)
There was a problem hiding this comment.
Round 2 (re-run on the same head) — reviewed head 12176257 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: nothing blocking — 2 advisory notes.
2 findings attached to the lines below.
Verdict: 2 advisory findings, no blocking findings. The general lens found a missing default explicit-stop refusal-path test. The prose lens supplied a clearer replacement comment. Rejected: none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of #497 ("fewer tests, each testing one behavior, so a change breaks only the tests about it"):
tests/test_orchestrator.pyonly, test-only, no behavior changes.run_dirandrefusal_receiptsreplace repeated setup.orchestrator.pystatements missed (this file alone)orchestrator.pypartial branchesEqual coverage was not enough: the first pass (154 tests) kept coverage but dropped behaviors (per-prefix refusal handling, GPU-type mismatch, the sibling wake dependency, the implicit-stop path, exact regression boundaries including infinities, the brief's ledger baseline, violating-path truncation, workspace export of refusals, the single-node budget boundary). Two codex rounds found them, and they are restored, mostly as main's original assertions.
Full gate: ruff, format, mypy, pytest (3158 passed, 7 skipped).
Built by DeepSeek-V4.1-Flash; reviewed by codex (two rounds) and Claude.