fix(ocs): [OCISDEV-1435] announce vault storage provider on every capabilities response - #747
Closed
gauravsoni119 wants to merge 1 commit into
Closed
gauravsoni119 wants to merge 1 commit into
gauravsoni119 wants to merge 1 commit into
Conversation
…abilities response
gauravsoni119
force-pushed
the
fix/ocisdev-1435-announce-vault-storage-provider
branch
from
September 23, 2026 09:35
4069e69 to
3c70782
Compare
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
deyankiteworks
approved these changes
Sep 23, 2026
Author
|
Closing this. We're fixing it on the web side instead: web now uses the vault storage provider id as a constant, like the share jail and OCM ids, so no reva change is needed. See owncloud/ocis#13001. Thanks for the suggestion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vault_storage_providerwas only filled in oncapabilities?vault=true, so clients outside the vault gotvault.enabled: truewith an empty provider id. Their vault checks never matched: a vault permanent link opened in a normal tab failed to resolve, vault notifications leaked into the Drive view, and the invite form didn't recognize vault resources.The id is a fixed constant, not a secret, so it is now set once in
Initwhenever vault mode is enabled and appears in every capabilities response. The?vault=truebranch also no longer mutates the handler's shared capabilities struct, which made the old behaviour intermittent.Tests: new unit tests in
capabilities_test.go(fail on the old code, pass with the fix).Jira: OCISDEV-1435