Skip to content

fix(ocs): [OCISDEV-1435] announce vault storage provider on every capabilities response - #747

Closed
gauravsoni119 wants to merge 1 commit into
mainfrom
fix/ocisdev-1435-announce-vault-storage-provider
Closed

gauravsoni119 wants to merge 1 commit into
mainfrom
fix/ocisdev-1435-announce-vault-storage-provider

Conversation

@gauravsoni119

Copy link
Copy Markdown

vault_storage_provider was only filled in on capabilities?vault=true, so clients outside the vault got vault.enabled: true with an empty provider id. Their vault checks never matched: a vault permanent link opened in a normal tab failed to resolve, vault notifications leaked into the Drive view, and the invite form didn't recognize vault resources.

The id is a fixed constant, not a secret, so it is now set once in Init whenever vault mode is enabled and appears in every capabilities response. The ?vault=true branch also no longer mutates the handler's shared capabilities struct, which made the old behaviour intermittent.

Tests: new unit tests in capabilities_test.go (fail on the old code, pass with the fix).

Jira: OCISDEV-1435

@gauravsoni119
gauravsoni119 requested a review from a team as a code owner September 23, 2026 09:35
@gauravsoni119
gauravsoni119 force-pushed the fix/ocisdev-1435-announce-vault-storage-provider branch from 4069e69 to 3c70782 Compare September 23, 2026 09:35
@kw-security

kw-security commented Sep 23, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gauravsoni119 gauravsoni119 self-assigned this Sep 24, 2026
@gauravsoni119

Copy link
Copy Markdown
Author

Closing this. We're fixing it on the web side instead: web now uses the vault storage provider id as a constant, like the share jail and OCM ids, so no reva change is needed. See owncloud/ocis#13001. Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants