Skip to content

Render templates and related business messages across live traffic and history - #256

Merged
jlucaso1 merged 6 commits into
mainfrom
feat/template-rendering
Oct 26, 2026
Merged

jlucaso1 merged 6 commits into
mainfrom
feat/template-rendering

Conversation

@jlucaso1

@jlucaso1 jlucaso1 commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Business notifications can appear as [template], especially interactive templates whose stored rows have no denormalized body. Live reception and history also decode different subsets of business content.

Add a bounded shared projection for hydrated and interactive templates, legacy buttons/lists, business responses and readable carousel text. The GUI renders formatted header/body/footer, lazy header attachments and choice labels with visible explanations for unsupported actions. Historical rows recover display text from their stored protobuf; daemon/CLI summaries and quoted messages use the same projection. Business rendering carries no response IDs or native-flow payloads and executes no business actions.

Retained selections identify both the owning message and its displayed segment. Accepted deletion discards the business projection, and UI queue budgeting includes every owned business string and choice allocation. Shared context extraction resolves mentions in outer templates, nested interactive content and business attachments on both live reception and durable reload. Coverage, limits and pinned official Web source evidence are documented in docs/message-coverage.md.

Validation:

  • Initial full core/chat-store suite passed; the correction batch passed focused business tests across core, store, session, daemon and GUI.
  • Synthetic coverage includes SQLite reopen, old template rows without text, nested wrappers, native render assertions, header/footer selection preservation and invalidation, deletion cleanup, per-field queue budgeting and live/history mention resolution.
  • Fresh binary regression filters passed: mentions, quotes, UI queue, retained selection, offline/cache, call alerts and message actions.
  • Changed-crate all-target/all-feature Clippy passed with -D warnings; formatting and diff checks passed.
  • Local WASM compilation remains blocked before compilation by mbx metadata probing; direct Cargo metadata succeeds. Exact-head CI supplies browser, MSRV, Windows and macOS qualification.

Fixtures and examples are synthetic. Existing FTS entries for old templates are not rebuilt; native-flow execution, business button actions, untranslated template localization and carousel media remain unsupported with safe display fallbacks.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T22:41:44.506677Z 503cccf Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 250be34f47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/gui/src/components/message_bubble/business.rs Outdated
Comment thread crates/gui/src/components/message_bubble/mod.rs
Comment thread crates/core/src/chat/message.rs
@greptile-apps

greptile-apps Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new blocking issue was found.

Summary

Adds shared business-message display across live reception, history, quotes and daemon summaries.

  • Business messages share one bounded, display-only content card.
  • Live and stored business messages keep their text, context, and attachments.
  • The message view shows business cards with separately selectable text.
  • Text summaries show business content and queue budgets count it.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  P[Decoded message] --> N[Normalize wrappers]
  N --> B[Shared business projection]
  B --> L[Live message]
  B --> H[Historical message]
  L --> G[GUI card]
  H --> G
  L --> D[Daemon summary]
  H --> D
  N --> Q[Quoted summary]
Loading

Reviews (3) · Last reviewed commit: "Integrate main account consolidation int..." · Reviewed by Greptile

Comment thread crates/gui/src/components/message_bubble/mod.rs
Comment thread crates/session/src/mentions.rs Outdated

Copy link
Copy Markdown
Member Author

@codex review

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 503cccf439

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jlucaso1
jlucaso1 marked this pull request as ready for review October 26, 2026 22:40
@jlucaso1
jlucaso1 merged commit 121a3ea into main Oct 26, 2026
17 of 18 checks passed
@jlucaso1
jlucaso1 deleted the feat/template-rendering branch October 26, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant