Repository navigation
[fix] a stopped meeting's cockpit never shows the tree, and one with no report goes Home - #574
Merged
Merged
Conversation
…no report goes Home v0.32.1 held the tree back only while the save was in flight. A meeting that ended without a report (too short for Rust to keep, or nothing transcribed, e.g. a 2-second start/stop whose only line was still partial) cleared the finalizing flag and stayed on its cockpit, so the tree came back beside the coach: the four-column frame again. - cockpitHold replaces finalizingHold: the tree stays hidden for as long as a stopped meeting's cockpit is on screen, whatever the save is doing. Cmd+B still peeks. - leaveStoppedCockpit: a discarded recording (Rust) or a skipped save (no transcript) goes Home with a toast saying why, unless the user already moved on or started another meeting. - A failed save stays on the cockpit (its transcript is the only copy on screen) and now shows an error toast instead of looking like a slow save.
3 tasks
✅ SonarQube Quality Gate passed — pathorsAI_parley0 open issues on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A stopped meeting's cockpit never shows the left tree, and a meeting that ends without a report goes Home with a message saying why.
Why
#543 (v0.32.1) held the tree back only while the save was in flight. A meeting that ended without a report — too short for Rust to keep, or nothing transcribed — cleared the finalizing flag and stayed on its cockpit, so the tree came back beside the three coach columns: the four-column frame again. Reproduced from a user's log (2026-10-04 23:21): a 2-second start/stop whose only line was still a partial →
history: live save skipped (no transcript)→ stuck on a four-column cockpit.How
cockpitHoldreplacesfinalizingHold(lib/shell/sidebar.ts): the tree stays hidden for as long as a stopped meeting's cockpit is on screen, whatever the save is doing. ⌘B still peeks without touching the saved preference.leaveStoppedCockpit(lib/history/history.ts): a recording Rust discarded (too short) or a live save skipped for no transcript goes Home with a toast (meeting.notSaved.tooShort/.noTranscript), unless the user has already moved on or started another meeting.meeting.notSaved.failed) instead of looking like a slow save.How it was verified
bunx tsc --noEmitpassesbunx vitest runpasses (791)leaveStoppedCockpitlands on Home with the tree and the toast. Tauri app end-to-end not yet run.sidebar.test.tsrewritten for the cockpit hold,history.test.tscoversleaveStoppedCockpitzh-TWandenRefs #544.