Repository navigation
docs: CI flow, root README version, path-filtered CI - #131
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Mixed-file changes can trigger both CI workflows, producing successful no-op build and test checks alongside identically named real checks instead of an exclusive fallback.
1 open issue
What changed in this PR
This PR clarifies the SPFx image release process and aims to avoid expensive image builds for documentation-only changes while preserving required CI checks.
Changes:
- Documents workflow responsibilities and publishing via version tags on main.
- Adds the current SPFx version, 1.24.2, to the root README.
- Adds CI path filters and a lightweight fallback workflow for changes outside image inputs.
| File | Description |
|---|---|
| README.md | Displays the current SPFx version in the Docker Hub overview text. |
| AGENTS.md | Clarifies release tagging, workflow behavior, and README version updates. |
| .github/workflows/ci.yml | Filters CI runs to image inputs and the workflow itself. |
| .github/workflows/ci-skip.yml | Adds no-op build and test checks intended for non-image changes. |
Review effort: Balanced
Comment on lines
+17
to
+20
| paths-ignore: | ||
| - Dockerfile | ||
| - docker-bake.hcl | ||
| - .github/workflows/ci.yml |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
vX.Y.Ztag push on main is what publishes a release; never tag the release branchci.ymlnow runs only whenDockerfile,docker-bake.hcl, or the workflow itself changes. Newci-skip.ymlreports the requiredbuildandtestchecks as passed for every other change, so docs-only PRs stay mergeable without a multiplatform buildTest plan
ci-skip.ymlshould reportbuildandtestinstantly andci.ymlshould not run🤖 Generated with Claude Code