Skip to content

docs: CI flow, root README version, path-filtered CI - #131

Merged
DonKirkham merged 3 commits into
mainfrom
docs/ci-flow
Nov 20, 2026
Merged

DonKirkham merged 3 commits into
mainfrom
docs/ci-flow

Conversation

@DonKirkham

Copy link
Copy Markdown
Collaborator

Summary

  • AGENTS.md: document the three workflows and that the vX.Y.Z tag push on main is what publishes a release; never tag the release branch
  • Root README: show the current version in parentheses in the note under the title (this README is the Docker Hub description)
  • CI: ci.yml now runs only when Dockerfile, docker-bake.hcl, or the workflow itself changes. New ci-skip.yml reports the required build and test checks as passed for every other change, so docs-only PRs stay mergeable without a multiplatform build

Test plan

  • This PR touches only docs and workflows, so ci-skip.yml should report build and test instantly and ci.yml should not run
  • After merge, run "Update Docker Hub Description" manually to pick up the README note

🤖 Generated with Claude Code

  • docs: explain the CI flow and that the tag push publishes the release
  • docs: show the current version in the root README note
  • ci: only build the image when files that affect it change

DonKirkham and others added 3 commits November 20, 2026 08:02
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 20, 2026 14:21
@DonKirkham
DonKirkham marked this pull request as ready for review November 20, 2026 14:22
@DonKirkham
DonKirkham merged commit e3ae90c into main Nov 20, 2026
5 checks passed
@DonKirkham
DonKirkham deleted the docs/ci-flow branch November 20, 2026 14:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Mixed-file changes can trigger both CI workflows, producing successful no-op build and test checks alongside identically named real checks instead of an exclusive fallback.

1 open issue
What changed in this PR

This PR clarifies the SPFx image release process and aims to avoid expensive image builds for documentation-only changes while preserving required CI checks.

Changes:

  • Documents workflow responsibilities and publishing via version tags on main.
  • Adds the current SPFx version, 1.24.2, to the root README.
  • Adds CI path filters and a lightweight fallback workflow for changes outside image inputs.
File Description
README.md Displays the current SPFx version in the Docker Hub overview text.
AGENTS.md Clarifies release tagging, workflow behavior, and README version updates.
.github/​workflows/​ci.yml Filters CI runs to image inputs and the workflow itself.
.github/​workflows/​ci-skip.yml Adds no-op build and test checks intended for non-image changes.

Review effort: Balanced

Comment on lines +17 to +20
paths-ignore:
- Dockerfile
- docker-bake.hcl
- .github/workflows/ci.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants