Repository navigation
Submit project templates with one SDK attempt - #313
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughTemplate submissions now make one network attempt, regardless of retry overrides. Documentation describes submission outcomes and recovery after a lost response. A test verifies that a server error rejects without a second POST. ChangesTemplate submission
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Template submissions make one SDK attempt, and the checked-in API contract documents validation before submission without a replay guarantee. The changed behavior is covered by a test that checks only one request, so no actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Local review (head |
MessagingClient.templates.submitalready had a typed request and response, but it inherited client retry settings for a provider create operation. It now makes one network attempt even when a caller supplies an idempotency key or retry override (the route declares no replay contract). The README shows submission and directs callers to read the Number's Meta template catalog after a lost response or before treating a submission as approved.API source: polymorfa/polymorfa PR #377, merged; pinned through SDK
devcontracts at APIdev29abb7b66a8e225af4df5cf354e9836ccb2ce04c(merged with SDK #308).templates.submitforces one attempt; new test asserts one request with a key and retry override. Method, fields and types unchanged.Verification: typecheck, focused template tests (8) pass; CI on this head.
Summary by CodeRabbit