This repository was archived by the owner on Sep 30, 2026. It is now read-only.
Repository navigation
Parse DISABLE_CUPTI_LAZY_REINIT by value (#1568) - #1568
Merged
Merged
Conversation
|
@sanrise has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120578573. |
sanrise
added a commit
to sanrise/kineto
that referenced
this pull request
Sep 17, 2026
Summary: **Problem** Setting `DISABLE_CUPTI_LAZY_REINIT=0` unexpectedly disables lazy CUPTI reinitialization. **Why** The code checks only whether the environment variable exists, so every value is treated as enabled. **Fix** Disable lazy reinitialization only when the variable is set to `1`, matching `TEARDOWN_CUPTI` parsing. Reviewed By: ryanzhang22 Differential Revision: D120578573
sanrise
force-pushed
the
export-D120578573
branch
from
September 17, 2026 21:36
0acbf93 to
d761fd4
Compare
sanrise
added a commit
to sanrise/kineto
that referenced
this pull request
Sep 17, 2026
Summary: **Problem** Setting `DISABLE_CUPTI_LAZY_REINIT=0` unexpectedly disables lazy CUPTI reinitialization. **Why** The code checks only whether the environment variable exists, so every value is treated as enabled. **Fix** Disable lazy reinitialization only when the variable is set to `1`, matching `TEARDOWN_CUPTI` parsing. Reviewed By: ryanzhang22 Differential Revision: D120578573
sanrise
force-pushed
the
export-D120578573
branch
from
September 17, 2026 21:58
d761fd4 to
300883f
Compare
sanrise
added a commit
to sanrise/kineto
that referenced
this pull request
Sep 24, 2026
Summary: **Problem** Setting `DISABLE_CUPTI_LAZY_REINIT=0` unexpectedly disables lazy CUPTI reinitialization. **Why** The code checks only whether the environment variable exists, so every value is treated as enabled. **Fix** Disable lazy reinitialization only when the variable is set to `1`, matching `TEARDOWN_CUPTI` parsing. Reviewed By: ryanzhang22 Differential Revision: D120578573
sanrise
force-pushed
the
export-D120578573
branch
from
September 24, 2026 02:49
300883f to
e76eec3
Compare
sanrise
added a commit
to sanrise/kineto
that referenced
this pull request
Sep 24, 2026
Summary: **Problem** Setting `DISABLE_CUPTI_LAZY_REINIT=0` unexpectedly disables lazy CUPTI reinitialization. **Why** The code checks only whether the environment variable exists, so every value is treated as enabled. **Fix** Disable lazy reinitialization only when the variable is set to `1`, matching `TEARDOWN_CUPTI` parsing. Reviewed By: ryanzhang22 Differential Revision: D120578573
sanrise
force-pushed
the
export-D120578573
branch
from
September 24, 2026 02:51
e76eec3 to
66c129d
Compare
Summary: Pull Request resolved: pytorch#1568 **Problem** Setting `DISABLE_CUPTI_LAZY_REINIT=0` unexpectedly disables lazy CUPTI reinitialization. **Why** The code checks only whether the environment variable exists, so every value is treated as enabled. **Fix** Disable lazy reinitialization only when the variable is set to `1`, matching `TEARDOWN_CUPTI` parsing. Reviewed By: ryanzhang22 Differential Revision: D120578573
sanrise
force-pushed
the
export-D120578573
branch
from
September 24, 2026 02:53
66c129d to
dfb68bd
Compare
This was referenced Sep 24, 2026
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 25, 2026
Last one! Includes the following commits: - [Kineto] Exclude test on windows (pytorch/kineto#1575) 638a3ef - Opt-in per-thread activity buffers on the ROCm HIP path (pytorch/kineto#1573) 5dc9333 - Parse DISABLE_CUPTI_LAZY_REINIT by value (pytorch/kineto#1568) f140a13 - [Kineto] Add lookback window and sampling interval as config options (pytorch/kineto#1561) fcda441 - [xpupti] Don't emit ac2g flow endpoints on XPU_DRIVER records (pytorch/kineto#1549) f0df071 Pull Request resolved: #198560 Approved by: https://github.com/sanrise Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Problem
Setting
DISABLE_CUPTI_LAZY_REINIT=0unexpectedly disables lazy CUPTI reinitialization.Why
The code checks only whether the environment variable exists, so every value is treated as enabled.
Fix
Disable lazy reinitialization only when the variable is set to
1, matchingTEARDOWN_CUPTIparsing.Reviewed By: ryanzhang22
Differential Revision: D120578573