Parse DISABLE_CUPTI_LAZY_REINIT by value (#1568)

libkineto/src/CuptiActivityApi.cpp

@@ -28,12 +28,11 @@ constexpr size_t kBufSize(4 * 1024 * 1024);
 constexpr uint32_t kCuptiBufferRejectionMinVersion = 27;
 
 inline bool cuptiTearDown_() {
-  auto teardown_env = getenv("TEARDOWN_CUPTI");
-  return teardown_env != nullptr && strcmp(teardown_env, "1") == 0;
+  return isEnvVarSetToOne("TEARDOWN_CUPTI");
 }
 
 inline bool cuptiLazyInit_() {
-  return cuptiTearDown_() && getenv("DISABLE_CUPTI_LAZY_REINIT") == nullptr;
+  return cuptiTearDown_() && !isEnvVarSetToOne("DISABLE_CUPTI_LAZY_REINIT");
 }
 
 inline void reenableCuptiCallbacks_(CuptiCallbackApi& cbapi) {

libkineto/src/CuptiActivityApi.h

@@ -10,10 +10,12 @@
 
 #include <atomic>
 #include <condition_variable>
+#include <cstdlib>
 #include <functional>
 #include <memory>
 #include <mutex>
 #include <set>
+#include <string_view>
 
 #include <cupti.h>
 
@@ -27,6 +29,11 @@ namespace KINETO_NAMESPACE {
 
 using namespace libkineto;
 
+inline bool isEnvVarSetToOne(const char* name) {
+  const auto* value = std::getenv(name);
+  return value != nullptr && std::string_view{value} == "1";
+}
+
 class CuptiActivityApi {
  public:
   enum CorrelationFlowType { Default, User };

libkineto/test/CuptiActivityProfilerTest.cpp

@@ -345,6 +345,17 @@ class MockCuptiActivities : public CuptiActivityApi {
   bool available{true};
 };
 
+TEST(CuptiActivityApiTest, ParsesBooleanEnvironmentValues) {
+  constexpr auto* kTestEnvVar = "KINETO_TEST_BOOLEAN_ENV_VAR";
+  EXPECT_EQ(unsetenv(kTestEnvVar), 0);
+  EXPECT_FALSE(isEnvVarSetToOne(kTestEnvVar));
+  EXPECT_EQ(setenv(kTestEnvVar, "0", 1), 0);
+  EXPECT_FALSE(isEnvVarSetToOne(kTestEnvVar));
+  EXPECT_EQ(setenv(kTestEnvVar, "1", 1), 0);
+  EXPECT_TRUE(isEnvVarSetToOne(kTestEnvVar));
+  EXPECT_EQ(unsetenv(kTestEnvVar), 0);
+}
+
 TEST(CuptiActivityApiTest, KeepsReturningValidBuffersWhenRejectionUnsupported) {
   CallbackCuptiActivityApi cupti;
   cupti.canRejectBuffer_ = false;