Repository navigation
Fix job env loop hang and memory handling in spank_qrmi - #203
Merged
Merged
Conversation
A job environment entry that starts with {resource}_QRMI_ but has no
'=' skipped the index increment, so slurmstepd looped forever.
Also free the strdup'd acquisition token with free() instead of
qrmi_string_free(), free the QRMI config and the loaded job info,
use %zu/%td for size_t/ptrdiff_t, and log why the job fails when its
time limit cannot be read.
awennersteen
marked this pull request as ready for review
September 29, 2026 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
{resource}_QRMI_but has no=skipped theindex++, so slurmstepd looped forever. The loop is now afor.strdup()but was freed withqrmi_string_free()(RustCString::from_raw); it is now freed withfree().%zu/%tdforsize_t/ptrdiff_t, and log why the job fails when its time limit cannot be read.Testing
-Wall -Wextraagainst libslurm 23.11 (Ubuntu 24.04).=is skipped, loop terminates).