Repository navigation
Fail the job when one of its QPU resources cannot be acquired - #205
Merged
Merged
Conversation
With --qpu=A,B, a failed acquire of B only logged an error and the job ran with A alone; the user never saw the deferred error. Mark the init as failed so slurm_spank_task_init() reports the error and cancels the job, and stop acquiring further resources. Anything already acquired is released in slurm_spank_exit(). Unknown resource names are still ignored, as documented.
awennersteen
marked this pull request as ready for review
September 29, 2026 10:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
With
--qpu=A,B, a failed acquire of B only logged an error and the job ran with A alone; the user never saw the deferred error. Now the init is marked as failed, further acquisitions stop, andslurm_spank_task_init()reports the error and cancels the job. Resources acquired before the failure are released inslurm_spank_exit(), which runs unconditionally.Unknown resource names are still ignored, as documented. README describes the new behaviour.
This is a behavior change. Happy to discuss if this is desired or not.