Skip to content

github: honour LINUXKIT_PKG_ORG when exporting the EVE image from cache - #255

Merged
europaul merged 1 commit into
masterfrom
fix/cache-export-pkg-org
Oct 7, 2026
Merged

europaul merged 1 commit into
masterfrom
fix/cache-export-pkg-org

Conversation

@europaul

@europaul europaul commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The build-eve action and the riscv64 step export the EVE image from the linuxkit cache as the hardcoded lfedge/eve:<version>.
  • Runners that set LINUXKIT_PKG_ORG (our lab runners point it at the Zot registry namespace 10.208.13.77:5050/lfedge) get the image tagged under that org, so linuxkit cache export fails with could not find image or index for docker.io/lfedge/eve:<version>. The cache lookup is an exact-name match on the stored reference.
  • Use ${LINUXKIT_PKG_ORG:-lfedge} so the export asks for the name linuxkit wrote. Unchanged behaviour where the variable is unset.

Test plan

Context: EV-2862 (replace local registries on kratos with Zot).

🤖 Generated with Claude Code

The build-eve action and the riscv64 build step export the EVE image
from the linuxkit cache under the hardcoded name lfedge/eve:<version>.
When a runner sets LINUXKIT_PKG_ORG (e.g. to point linuxkit at a local
registry namespace such as 10.208.13.77:5050/lfedge), linuxkit tags the
built image under that org instead, and 'linuxkit cache export' fails
with 'could not find image or index for docker.io/lfedge/eve:<version>'
because the cache lookup is an exact-name match.

Derive the org from LINUXKIT_PKG_ORG, falling back to lfedge, so the
export asks for the name linuxkit actually wrote.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Paul Gaiduk <paulg@zededa.com>
@europaul
europaul requested a review from eriknordmark as a code owner October 7, 2026 13:48
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Claude finished @europaul's task in 1m 29s —— View job


Review: honour LINUXKIT_PKG_ORG when exporting the EVE image

  • Read the diff and traced the image-naming path
  • Verified the fix against how the image is stored in the linuxkit cache
  • Checked for other call sites with the same hardcoded org

Verdict: the fix is correct. 👍

LINUXKIT_PKG_ORG is consumed by linuxkit itself and overrides the org: lfedge from pkg/eve/build.yml, so make eve stores the image in the cache as <LINUXKIT_PKG_ORG>/eve:<version>-<hv>. linuxkit cache export matches on the exact stored reference, so the export must ask for the same org. Resolving ${LINUXKIT_PKG_ORG:-lfedge} at export time matches what the build wrote, and the :-lfedge default preserves behaviour when the variable is unset. Both touched sites (build-eve/action.yml and the riscv64 step in build.yml) use shell: bash, so the parameter expansion is valid, and a value containing a registry host (10.208.13.77:5050/lfedge) flows through unchanged.

One cross-cutting note (out of scope for this diff)

.github/workflows/assets.yml still hardcodes lfedge/eve:... in the "Pull the EVE release from DockerHUB or build it" step. Its else branch runs make ... eve and then docker run lfedge/eve:...; on a runner with LINUXKIT_PKG_ORG set, make eve would tag the image under that org and the subsequent docker run would fail for the same reason this PR fixes. It's a different workflow and not part of this change, but if those lab runners also exercise assets.yml, it will need the same treatment.

No blocking issues — this is good to merge for its stated purpose.
· branch fix/cache-export-pkg-org

@europaul
europaul merged commit b6df8b9 into master Oct 7, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant