Repository navigation
[Bug Fix] DataTablePerPageSelect: match shadcn's Select and submit without an inline onchange - #579
Merged
cirdes merged 10 commits intoNov 6, 2026
Conversation
…nchange Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pierry01
marked this pull request as ready for review
October 29, 2026 03:23
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
…ta is left untouched Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pierry01
deleted the
fix/data-table-per-page-select-without-inline-handler
branch
November 3, 2026 17:09
pierry01
restored the
fix/data-table-per-page-select-without-inline-handler
branch
November 3, 2026 17:13
…e-handler Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cirdes
requested changes
Nov 5, 2026
cirdes
left a comment
cirdes
left a comment
Collaborator
There was a problem hiding this comment.
@pierry01, great timing on this PR. Over the last few days I refactored every ruby-ui component to match shadcn exactly, and I created a skill called /shadcn-audit or something close to that. It runs a full comparison between our component and the shadcn one.
Could you run that skill so it takes the screenshots and does the audit, then request review again? Thanks!
pierry01
changed the title
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
…n SelectInput's actions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
shadcn audit
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, toolbar spacing) (ruby-ui#659) * [Bug Fix] DataTable: toggle trigger as a toolbar flex item, dashboard-01 status badges in the audit fixture DataTableColumnToggle's wrapper and its DropdownMenu root are display: contents, so the Columns button is a flex item of the toolbar like shadcn's trigger (its inline-flex blockifies to flex). The audit fixture's badges follow the dashboard-01 block (default size, px-1.5 text-muted-foreground, CircleCheck/Loader status icons), and the native checkbox's display and text-align differences are registered as divergences. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * [Bug Fix] DataTableToolbar: 24px before the table, as dashboard-01 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
cirdes
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
None opened, small self-contained fix.
Description
DataTablePerPageSelectsubmitted through an inlineonchange="this.form.requestSubmit()", which a Content-Security-Policy without'unsafe-inline'blocks, so changing the page size did nothing there. It now submits through aruby-ui--data-table-per-page-selectStimulus controller.After the shadcn audit it also renders as shadcn's dashboard-01 block does:
RubyUI::SelectwithSelectTrigger size: :sm, class: "w-20"labelled by the<label for>and the list opening on top, instead of aNativeSelect.SelectInputcarriesname/valueand the submit controller: picking a size fireschangethere and the form submitsGET ?per_page=N(search and sort kept, page reset) into the Turbo Frame. The public API of the component is unchanged.The server-driven submit is registered in
audit/divergences/data_table.yml, and the component map'sDataTablePerPageSelectselector now points at the trigger.shadcn audit · main
shadcn audit · this PR
The two ❌ left (Columns trigger and row checkbox
display) are pre-existing and go to a separate PR, together with the menu behavior this audit didn't cover.Testing instructions
cd gem && bundle exec rake→ 780 runs, 0 failures, StandardRB clean.cd mcp && bundle exec rake→ 33 runs, 0 failures./docs/data_table_demo: open "Rows per page" and pick 10 → the frame reloads with 10 rows.5→ 50, Enter →?per_page=50. Esc closes it and focus returns to the trigger.on*attribute.🤖 Generated with Claude Code