Repository navigation
feat: replace tungstenite with a shared WebSocket engine - #26
Merged
Merged
Conversation
Use the same bounded, buffered WebSocket protocol engine on Tokio and Compio, including GraphQL integration, examples, migration docs and Autobahn CI. Resolve review M1-M7: idempotent close replies, no deferred pong after close, validated allocation limits, rejected oversized controls, accurate docs, socket and driver tests on both runtimes, and concise Autobahn script docs. Also cover zero write thresholds and valid gateway close code 1014. Validation: standalone workspace tests with ws/async-graphql and all features; all-features Clippy; 77 WebSocket tests on each runtime; Autobahn 247/247 on Tokio and Compio; 1,648,034 fuzz inputs without a crash.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
tokio-tungsteniteandcompio-wswith one WebSocket engine for Tokio and Compio.WebSocketUpgradereplacesTakoWs; sends are buffered, with explicitflush()support.Includes GraphQL integration, updated examples and migration docs, bounded ping/pong buffering, close handling, repeated subprotocol headers, and buffer/payload validation.
Checks: workspace tests with
ws,async-graphqland all features, Clippy, 79 WebSocket tests per runtime, Autobahn 247/247 on both runtimes, and 1.65M fuzz inputs without a crash.