Skip to content

Rollup of 11 pull requests - #162434

Merged
rust-bors[bot] merged 47 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-kGs5tvl
Sep 7, 2026
Merged

Rollup of 11 pull requests#162434
rust-bors[bot] merged 47 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-kGs5tvl

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Sep 7, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

The rustc-josh-sync Cronjob Bot and others added 30 commits September 4, 2026 07:05
This updates the rust-version file to 71238e2.
…O is enabled

The parallel frontend makes the cookies nondeterministic in their
current form, resulting in nondeterministic outputs when bitcode is
emitted or LTO is used.

Causes minor diagnostic regression for inline asm in release builds.
This updates the rust-version file to 32d94cc.
…e-test-link

Update links for test-x86_64-gnu-debug and test-aarch64-gnu-debug
This test demonstrates the existing crash, and will be migrated to a successful
coverage test in a subsequent commit.

Co-Authored-By: Rachel Barker <rachel.barker@ferrous-systems.com>
Compile-time-only functions don't generate code, so instrumenting them for
coverage is useless.

This also avoids an ICE when trying to get the function's symbol name for an
unused-function record, which can occur when instrumenting `core`.

Co-Authored-By: Rachel Barker <rachel.barker@ferrous-systems.com>
In all cases, the caller was passing `&self.thir[scrutinee_id].span`, which can
just as easily be done by the callee. There's no need to add confusion by
passing a separate span.
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Sep 7, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-gnu-llvm-21-3,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc-1,test-i686-msvc-2,test-armhf-gnu

@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 518b847 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
Rollup of 11 pull requests


try-job: dist-various-1
try-job: test-various
try-job: test-x86_64-gnu-aux
try-job: test-x86_64-gnu-llvm-21-3
try-job: test-x86_64-msvc-1
try-job: test-aarch64-apple-1
try-job: test-aarch64-apple-2
try-job: test-x86_64-mingw-1
try-job: test-i686-msvc-1
try-job: test-i686-msvc-2
try-job: test-armhf-gnu
@rust-bors

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 1805b1d (1805b1d4c2bab8a934e8129960f493a3548ee295)
Base parent: 656a9da (656a9da186dacaf3bf8f7f7296a825d256cb4ae3)

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2026
@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 5m 2s
Pushing f0bbd8d to main...

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 752b9bf (parent) -> f0bbd8d (this PR)

Test differences

Show 168 test diffs

Stage 1

  • [ui (polonius)] tests/ui/async-await/spurious-static-bound-issue-115376.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/consts/const-eval/do_not_const_check.rs: [missing] -> pass (J0)
  • mem::fn_ptr::test_typekind: [missing] -> pass (J2)
  • [ui] tests/ui/async-await/spurious-static-bound-issue-115376.rs: [missing] -> pass (J5)
  • [ui] tests/ui/consts/const-eval/do_not_const_check.rs: [missing] -> pass (J5)
  • [coverage-map] tests/coverage/comptime.rs: [missing] -> pass (J7)
  • [coverage-run] tests/coverage/comptime.rs: [missing] -> ignore (ignored when the profiler runtime is not available) (J7)
  • [run-make] tests/run-make/parallel-reproducible-inline-asm-cookie: [missing] -> pass (J7)
  • [ui] tests/rustdoc-ui/expect-item-after-attribute.rs: [missing] -> pass (J7)

Stage 2

  • [coverage-run] tests/coverage/comptime.rs: [missing] -> ignore (ignored when the profiler runtime is not available) (J1)
  • [coverage-run] tests/coverage/comptime.rs: [missing] -> pass (J3)
  • [coverage-map] tests/coverage/comptime.rs: [missing] -> pass (J4)
  • [coverage-run] tests/coverage/comptime.rs: [missing] -> ignore (ignored when cross-compiling) (J6)
  • [run-make] tests/run-make/parallel-reproducible-inline-asm-cookie: [missing] -> ignore (ignored when cross-compiling) (J6)
  • [run-make] tests/run-make/parallel-reproducible-inline-asm-cookie: [missing] -> ignore (ignored when the operating system and target environment are windows-gnu) (J8)
  • [ui] tests/ui/async-await/spurious-static-bound-issue-115376.rs: [missing] -> pass (J9)
  • [ui] tests/ui/consts/const-eval/do_not_const_check.rs: [missing] -> pass (J9)
  • mem::fn_ptr::test_typekind: [missing] -> pass (J10)
  • [ui] tests/rustdoc-ui/expect-item-after-attribute.rs: [missing] -> pass (J11)
  • [run-make] tests/run-make/parallel-reproducible-inline-asm-cookie: [missing] -> pass (J12)

Additionally, 148 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f0bbd8dfa962017309286c7feeea8b2ef9a881b0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-x86_64-gnu-stdlib-semver-check: 8m 47s -> 18m 20s (+108.7%)
  2. test-x86_64-gnu-gcc-core-tests: 11m 25s -> 18m 1s (+57.8%)
  3. test-x86_64-gnu-gcc: 1h 14m -> 1h 46m (+41.5%)
  4. test-x86_64-gnu-llvm-21: 40m 45s -> 57m 30s (+41.1%)
  5. dist-sparcv9-solaris: 1h 13m -> 1h 39m (+35.3%)
  6. test-x86_64-gnu-tools: 49m 7s -> 1h 6m (+34.8%)
  7. dist-riscv64-linux-musl: 1h 8m -> 1h 32m (+34.7%)
  8. dist-various-2: 49m 5s -> 33m 55s (-30.9%)
  9. test-i686-gnu-1: 2h 14m -> 1h 36m (-28.3%)
  10. dist-x86_64-msvc: 2h 27m -> 3h 3m (+24.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f0bbd8d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.7%, secondary 3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.9% [0.4%, 6.7%] 3
Regressions ❌
(secondary)
5.1% [2.1%, 7.0%] 3
Improvements ✅
(primary)
-2.5% [-4.3%, -0.7%] 2
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) 0.7% [-4.3%, 6.7%] 5

Cycles

Results (primary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.9% [0.6%, 1.1%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% [-0.8%, -0.5%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [-0.8%, 1.1%] 5

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 481.658s -> 479.3s (-0.49%)
Artifact size: 403.47 MiB -> 403.45 MiB (-0.01%)

@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#158153 avoid spurious lifetime diagnostic in async generic case c67df8219ff35cc1e07a728ebf8b85b2ece053a9
(link)
#160197 Restrict LLVM inline asm location cookie usage. Fixes #1504 3fc239c96336d07dba098c7d793afe100077e145
(link)
#162413 Unconditionally invalidate the library when the compiler ch… 67dd355a43c764e7ed8404e1e982dea3efaa4ea9
(link)
#162294 Reflection refactor ptrs 8476e1d5447068dd479c849b0d3c7aee029c42ef
(link)
#162354 Make comptime functions ineligible for coverage 1024850bd6b205b58b9ba983230a41eaffaf5000
(link)
#162379 add test ensuring we refuse to const-eval the body of a rus… 97eea34b71e66e0b0acbf8c089d304cd4957599d
(link)
#162386 Add a regression test for trailing attributes in doctests 7c98b0bd16008712dce19697729e406d05672a42
(link)
#162410 std: remove exceed whitespace in docs bcc42a4cb1f1c3f1ad2baffbbdf015613f5e48c7
(link)
#162420 mir_build: Don't pass a redundant scrutinee_span to some … 5cda84d155447a6f86ea0b5dc05a22fdaaef5f61
(link)
#162430 rustc-dev-guide subtree update 8a4d6d3f0d273c80dd3f536a19392dbb71d66e0b
(link)
#162431 add next-solver FIXMEs 6000bd96702f95099a98dc1db35a8a75809805ef
(link)

parent commit: 752b9bf879

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-bootstrap-stamp Area: bootstrap stamp logic A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parallel compiler: threads::spawnning loop not reproducible