refactor(cli/rustup-mode): avoid redundant allocs in target_add() - #5054
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
rami3l
force-pushed
the
refactor/target-add-allocs
branch
2 times, most recently
from
September 4, 2026 14:21
e699869 to
83f5d81
Compare
rami3l
marked this pull request as ready for review
September 4, 2026 14:23
rami3l
force-pushed
the
refactor/target-add-allocs
branch
3 times, most recently
from
September 4, 2026 14:48
4b61a97 to
cb9dc23
Compare
djc
reviewed
Sep 4, 2026
rami3l
force-pushed
the
refactor/target-add-allocs
branch
6 times, most recently
from
September 4, 2026 15:24
00055a8 to
d8fd968
Compare
rami3l
force-pushed
the
refactor/target-add-allocs
branch
from
September 7, 2026 08:59
d8fd968 to
81044d6
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
djc
approved these changes
Sep 7, 2026
Member
Author
@djc Sounds pretty much like a systematic replacement. I can do this as a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on a minor pre-existing issue discovered when reviewing #5042.
This patch avoids an extra
.to_string()allocation and a redundantinto_iter() -> collect() -> into_iter()round trip.