Repository navigation
feat(release): add independent manual-release asset integrity gate - #146
Merged
Merged
Conversation
14 of 31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add a cross-platform, offline integrity gate for the complete extracted manual GitHub Release upload set. Protects against partial uploads, stale version files, corrupted packages, unsafe archive paths, and mismatched SPDX metadata.
Implementation
packaging/verify_release_assets.py: validates four expected filenames and strictSHA256SUMS.txtcontents, independently hashes payloads with streaming reads, CRC-checks portable ZIP, checks for unsafe ZIP/TAR entries, verifies portable executable, SPDX 2.3 project version, and corresponding-source archive inventory.packaging/tests/test_verify_release_assets.py: 11 network-free positive/negative regression tests, automatically included in existing packaging unittest discovery.docs/releases/asset-verification.mdand manual release guide update with exact usage and limitations.Evidence
python -m unittest discover -s packaging/tests -p test_verify_release_assets.py -v) with synthetic archives. CI should run the full packaging suite and lint.Release freeze
Do not merge into
mainbefore completing or deliberately revalidating v1.4.0. The tested candidate remainseb64133409b9f43a89dcebeffee623c18a9b8182; merging changes the source SHA and requires fresh tests and assets. This improvement can be merged after stable publication or accompanied by a full new release-candidate validation.