Repository navigation
test(env_gateway): the never-ready site tests don't wait out the 30s margin - #625
Open
andrewpark-scaleai wants to merge 1 commit into
Open
andrewpark-scaleai wants to merge 1 commit into
andrewpark-scaleai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The goal is faster agentenv-framework CI with no test weakened. Two unit tests of a site that never says it's ready each waited out the full 30s
WEBSITE_READY_MARGIN_S. That's 60s of unit-tier time. The tests next to them already set the margin to 0.What
test_a_site_that_never_says_it_is_ready_fails_the_deploy_naming_whyandtest_a_site_whose_ready_answers_no_website_readiness_is_never_ready_and_the_deploy_says_sosetWEBSITE_READY_MARGIN_Sto 0. Together they take 2s instead of 63s.Coverage
I broke the readiness wait in
env_gateway_provider.pyeight ways:timeout_sargument is ignored.Verification
env_gateway_provider_test.pypass.

Confidence Score: 5/5
The PR appears safe to merge.Summary
Two never-ready-site tests set
WEBSITE_READY_MARGIN_Sto zero, removing the extra wait without changing production code.Reviews (1) · Last reviewed commit: "test(env_gateway): the never-ready site ..." · Reviewed by Greptile