Skip to content

test(env_gateway): the never-ready site tests don't wait out the 30s margin #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewpark-scaleai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(env_gateway): the never-ready site tests don't wait out the 30s margin #625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tst/unit/providers/env_providers/env_gateway_provider_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2667,7 +2667,9 @@ def site(request: httpx.Request) -> httpx.Response:


@pytest.mark.asyncio
async def test_a_site_that_never_says_it_is_ready_fails_the_deploy_naming_why():
async def test_a_site_that_never_says_it_is_ready_fails_the_deploy_naming_why(monkeypatch):
monkeypatch.setattr(env_gateway_provider, "WEBSITE_READY_MARGIN_S", 0)

def site(request: httpx.Request) -> httpx.Response:
if request.url.path.endswith("/.well-known/agent-env.json"):
return httpx.Response(200, json=_READY_CARD)
Expand All @@ -2680,7 +2682,9 @@ def site(request: httpx.Request) -> httpx.Response:


@pytest.mark.asyncio
async def test_a_site_whose_ready_answers_no_website_readiness_is_never_ready_and_the_deploy_says_so():
async def test_a_site_whose_ready_answers_no_website_readiness_is_never_ready_and_the_deploy_says_so(monkeypatch):
monkeypatch.setattr(env_gateway_provider, "WEBSITE_READY_MARGIN_S", 0)

def site(request: httpx.Request) -> httpx.Response:
if request.url.path.endswith("/.well-known/agent-env.json"):
return httpx.Response(200, json=_READY_CARD)
Expand Down