Repository navigation
Fix crash when turning volume past 100 - #8
Merged
Merged
Conversation
…on any crash Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing
+past 100 crashed sonic: mpv allows up to 150, and the 10-step volume meter tried to draw −1 empty steps. The crash also left mpv playing and the terminal without a cursor.SONIC_DEBUG=1adds the stack)Tested: on the Mac Studio, played a mix and pressed
+16 times to 150, then-20 times to 0. No crash, and the meter and number were right at both ends.🤖 Generated with Claude Code