Skip to content

Fix crash when turning volume past 100 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethmills21 merged 1 commit into from
Oct 16, 2026
Merged

Fix crash when turning volume past 100 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions bin/sonic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,21 @@ function cleanup(exitCode = 0) {
]).then(() => process.exit(exitCode));
}

// A crash must still stop the music and give the terminal back.
function crash(err) {
try { ui.cleanup(); } catch {}
if (player.proc) {
try { player.proc.kill('SIGKILL'); } catch {}
}
if (process.stdin.isTTY && process.stdin.isRaw) process.stdin.setRawMode(false);
console.error(`\nsonic hit a bug and stopped: ${err?.message || err}`);
console.error('please report it: https://github.com/sethmills21/sonic/issues');
if (process.env.SONIC_DEBUG) console.error(err?.stack);
process.exit(1);
}

process.on('uncaughtException', crash);
process.on('unhandledRejection', crash);
process.on('SIGINT', () => cleanup(0));
process.on('SIGTERM', () => cleanup(0));
process.on('exit', () => {
Expand Down
3 changes: 2 additions & 1 deletion lib/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,8 @@ export class UI {
const parts = [];
if (typeof options.volume === 'number') {
const steps = 10;
const filled = Math.round((options.volume / 100) * steps);
// mpv goes to 150; past 100 the meter stays full and the number keeps counting.
const filled = Math.max(0, Math.min(steps, Math.round((options.volume / 100) * steps)));
const meter = chalk.hex(theme.accent)('━'.repeat(filled)) + chalk.hex(theme.muted)('─'.repeat(steps - filled));
parts.push(`${chalk.hex(theme.muted)('vol')} ${meter} ${chalk.hex(theme.muted)(String(options.volume))}`);
}
Expand Down
Loading