Repository navigation
docs: list every role a source deploy needs, not just the first three - #123
Merged
Merged
Conversation
The runner service account's role list named run.admin, cloudbuild and serviceAccountUser and missed Artifact Registry and Storage. A source deploy uploads the source to a bucket, builds, then pushes the image, and it fails naming only the permission it is missing - so the list was corrected twice against real failures, once per missing permission. Documented as a table with the reason for each, so the next person grants them all at once instead of discovering them one deploy at a time.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+188
to
+189
| | `roles/artifactregistry.writer` | push the built image (else `artifactregistry.repositories.get` is denied) | | ||
| | `roles/storage.objectAdmin` | read/write the source bucket `run-sources-<project>-<region>` (else `storage.buckets.get` is denied) | |
Contributor
There was a problem hiding this comment.
🔍 Workflow comment still lists three roles
The authentication step's credential comment still names only three roles. Readers following that comment can miss the two roles added here.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented runner service-account roles were wrong twice, and each omission cost a failed deploy:
PERMISSION_DENIED: artifactregistry.repositories.getdoes not have storage.buckets.get access to ... run-sources-low-code-connect-us-west1gcloud run deploy --sourceuploads the source to a bucket, builds an image, then pushes it — each step needs its own permission, and gcloud reports only the first one missing. So the list is now complete, as a table with the reason for each, including the concrete bucket name.Docs only; no code change.