Skip to content

docs: list every role a source deploy needs, not just the first three #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgardoll merged 1 commit into from
Oct 4, 2026
Merged

docs: list every role a source deploy needs, not just the first three #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions DEPLOYMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,24 @@ from a repository secret. Until that secret exists the job **silently skips**
(rather than failing on every push), so set up this once or merged runner
changes will deploy nothing:

1. Create a service account with at least `roles/run.admin`,
`roles/cloudbuild.builds.editor` and `roles/iam.serviceAccountUser`, generate
a JSON key, and download it.
1. Create a service account and grant it every role a **source** deploy needs,
then generate a JSON key and download it. `gcloud run deploy --source` does
more than create the service: it uploads the source to a bucket, builds an
image, and pushes that image to Artifact Registry. Each step needs its own
permission, and the failure only ever names the first one it is missing, so
grant the lot up front:

| Role | Why |
| --- | --- |
| `roles/run.admin` | create and route the revision |
| `roles/iam.serviceAccountUser` | act as the runtime service account |
| `roles/cloudbuild.builds.editor` | run the build |
| `roles/artifactregistry.writer` | push the built image (else `artifactregistry.repositories.get` is denied) |
| `roles/storage.objectAdmin` | read/write the source bucket `run-sources-<project>-<region>` (else `storage.buckets.get` is denied) |
Comment on lines +188 to +189

@devin-ai-integration devin-ai-integration Bot Oct 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Workflow comment still lists three roles

The authentication step's credential comment still names only three roles. Readers following that comment can miss the two roles added here.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


Scope the last two to the repository and bucket if you prefer, but a partial
set fails at deploy time with a message naming only the next missing
permission — which is how this list was corrected twice.
2. In **Settings → Secrets and variables → Actions**, create a repository secret
named `CCC_FFAI_RUNNER_SA_KEY_JSON` whose value is the key's full JSON
(including the surrounding `{ }`).
Expand Down
Loading