Repository navigation
test(e2e): drop expects that cannot fail - #82
Merged
Merged
Conversation
The body stringify checks restated the fixture, and readLanguageDefault falls back to en, so those expects never saw a server failure. The case-alias test now skips when two names that differ only by case collide, so a pass means the copy assertions ran.
2 tasks
Contributor
Author
|
Reopening so E2E reruns against dev with the sitmun-shared publish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The preview and execute-child specs asserted a JSON string of the body the test had just built. Those expects pass even if the server starts requiring
appIdorterId.readLanguageDefaultreturnsenwhen the parameter is missing, sotoBeTruthy()on that result cannot fail. On a case-insensitive filesystem the case-alias test passed by assertingcreated == 0and never checked the copy.What changed
JSON.stringify(body)expects. The status and response property expects stay.toBeTruthy()expects onreadLanguageDefault. The later equality checks stay.test_alias_copies_lowercase_yaml_ref_on_case_sensitive_fscallsskipTestwhenprobeandPROBEare the same file.Scope
This covers the admin form specs and the extracted Liquibase helper test. It leaves the server contract, other
toBeTruthy()expects, and the rest of the tools tests unchanged.Blast Radius
A case-insensitive machine no longer records this test as a pass. The copy assertions run only when the filesystem can tell the two names apart. The specs still check the HTTP response.
Verification
python3 -m unittest tools.tests.test_prepare_extracted_liquibase -vfinished OK with one skip,filesystem is case-insensitive.npx playwright test --listlisted 61 tests in 23 files. Playwright was listed, not executed.