Skip to content

test(e2e): drop expects that cannot fail #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjlopez merged 1 commit into from
Oct 15, 2026
Merged

test(e2e): drop expects that cannot fail #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion e2e/admin/forms/language-default.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ async function readLanguageDefault(request: import('@playwright/test').APIReques
test.describe('Language default change', () => {
test('preview dialog cancel leaves language.default unchanged', async ({ page, request }) => {
const before = await readLanguageDefault(request);
expect(before).toBeTruthy();

// Open a non-default language (ca = 3 when default is en).
await page.goto('/#/language/3/languageForm');
Expand Down
1 change: 0 additions & 1 deletion e2e/admin/forms/template-default-language.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ test.describe('Templates + language.default i18n cluster', () => {
}) => {
test.setTimeout(120_000);
const initialDefault = await readLanguageDefault(request);
expect(initialDefault).toBeTruthy();
const otherLang = initialDefault === 'en' ? 'ca' : 'en';
const literalKey = `e2e-enroll-${uniqueValue('KEY')}`;
const translated = `e2e-translated-${uniqueValue('TR')}`;
Expand Down
2 changes: 0 additions & 2 deletions e2e/admin/forms/template-execute-child.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ test.describe('Plantilla template dry-run', () => {

const json = await response.json();
expect(json).toHaveProperty('html');
expect(JSON.stringify(body)).not.toMatch(/"appId"|"terId"/);
});

test('execute-child accepts ADMIN body without appId/terId', async ({ request }) => {
Expand Down Expand Up @@ -74,6 +73,5 @@ test.describe('Plantilla template dry-run', () => {
const json = await response.json();
expect(json).toHaveProperty('taskId', linkedTaskId);
expect(json).toHaveProperty('status');
expect(JSON.stringify(body)).not.toMatch(/"appId"|"terId"/);
});
});
16 changes: 7 additions & 9 deletions tools/tests/test_prepare_extracted_liquibase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,21 +89,19 @@ def test_alias_copies_lowercase_yaml_ref_on_case_sensitive_fs(self) -> None:
root = Path(tmp)
data = root / "changelog" / "04_initial_data_prod"
data.mkdir(parents=True)
(data / "probe").write_text("x", encoding="utf-8")
if (data / "PROBE").exists():
self.skipTest("filesystem is case-insensitive")
(data / "probe").unlink()
(data / "STM_USER.csv").write_text("USE_ID\n1\n", encoding="utf-8")
(root / "changelog" / "04_initial_data_prod.yaml").write_text(
" file: 04_initial_data_prod/stm_user.csv\n",
encoding="utf-8",
)
(data / "probe").write_text("x", encoding="utf-8")
case_sensitive = not (data / "PROBE").exists()
(data / "probe").unlink()
created = pel.alias_csv_case(root)
if case_sensitive:
self.assertEqual(created, 1)
self.assertTrue(pel.exists_exact(data / "stm_user.csv"))
self.assertTrue(pel.exists_exact(data / "STM_USER.csv"))
else:
self.assertEqual(created, 0)
self.assertEqual(created, 1)
self.assertTrue(pel.exists_exact(data / "stm_user.csv"))
self.assertTrue(pel.exists_exact(data / "STM_USER.csv"))


if __name__ == "__main__":
Expand Down
Loading