Repository navigation
test: lock application and territory seed filters - #348
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The seed counts in #312 do not lock the extra filter.
publicon territory 1 andinternalon territory 1 return the same applications as the unfiltered list, and application 1 returns the same territories as the unfiltered list. Dropping the territory or application predicate still passed.What changed
internalhas five applications. Territory 2 (Municipio B) returns the four role-1 titles and omitsSITMUN - Externa protegida, for both the restricted query and the public-catalog query.internalhas three territories. Application 5 returns onlyProvincia A, for both query variants.internalare the four titles, withtotalPages4 whensize=1.[Unreleased]### Changed records the test lock for #312.Scope
Tests and the changelog only. Production queries are unchanged. The existing filters already drop those rows; the assertions now require it.
Blast Radius
No API or schema change.
publicholds role 1 on every seed territory, so that user's page stays four titles on territory 2. The territory filter is locked byinternalon territory 2 (4 versus 5). The application filter is locked by application 5 (Provincia Aversus the three territories).Verification
./gradlew spotlessApplyand focusedApplicationRepositoryTest,TerritoryRepositoryTest,ClientConfigurationApplicationControllerTest, andClientConfigurationTerritoryApplicationsControllerTestpassed.spotlessCheck, the fulltesttask, andjacocoTestReport. All passed. LDAP port 8389 was free.Fixes #312