Repository navigation
test: stop booting a random port for repository tests - #349
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Five repository tests boot an embedded server with
RANDOM_PORTandRestTemplateto check HAL status and JSON. Sibling Data REST tests already cover that kind of contract with MockMvc on the shared context.What changed
DatabaseConnectionRepositoryIntegrationTest,RoleRepositoryIntegrationTest,TerritoryRepositoryIntegrationTest,TerritoryGroupTypeRepositoryIntegrationTest, andUserResourceIntegrationTestnow use@SpringBootTestwith@AutoConfigureMockMvc. Admin calls use@WithMockUser(roles = "ADMIN"). Each previous assertion stays, including user create, delete, and the following 404. The port-onlyTestUtils.adminAuthHeadershelper andClientHttpLoggerRequestInterceptorare removed. The unreleased changelog notes the change.Scope
Test code and the changelog only. No production paths. Liquibase JPA slice tests from #317 are unchanged.
Blast Radius
These classes no longer bind a server port. They join the existing MockMvc context. Cookie login remains covered by the authentication controller tests.
Verification
The five classes passed on their own. The pre-commit hook ran
spotlessCheck, the full H2testtask, andjacocoTestReport.Fixes #316