Repository navigation
fix(about): show the installed SITNA and OpenLayers versions - #219
Merged
Merged
Conversation
The About dialog still prints a hardcoded SITNA version and has no OpenLayers row. This fails until those values come from the installed packages.
The dialog copied sitnaVersion from the environment files, which stayed at 4.8.0 after api-sitna resolved to 4.9.1. Read both versions from the installed packages when the viewer is built. Fixes #218
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The About window said API SITNA 4.8.0 because that string was typed into the environment files. The installed package is 4.9.1. The window also omitted OpenLayers, which is the map library SITNA uses.
What changed
api-sitnaandolversions when the viewer is built.sitnaVersionfield is gone from the environment files.Scope
sitnaVersion. Drop that field when the stack pointer includes this commit. Dropping it earlier hides the row on the current viewer.Tradeoffs
Reading
package.jsonat build time keeps the window aligned after the next install. Writing 4.9.1 back into the environment files would repeat this bug.4.10.0 is the newest SITNA release, and it is not in this pull request. Its package is missing four control templates, it no longer brings
draggabilly, and its Cesium engine range conflicts withcesium1.142.Blast Radius
Anyone who opens About sees the SITNA and OpenLayers versions that this build installed. Map behavior is unchanged. The dependency range stays
^4.8.0, which resolves to 4.9.1.Verification
API SITNA Version: 4.8.0while the installed package was 4.9.1, then passed.npm testin the viewer: 123 suites, 1414 tests passed.npm run e2e:viewer: 58 passed, 1 skipped. The skip is the existing expired-cargo case inpassword-access.spec.ts.