Repository navigation
Upgrade egui to 0.36 and raise the MSRV to 1.95 - #30
Merged
Merged
Conversation
- Bump eframe, egui, egui_extras and egui-wgpu from 0.33 to 0.36. - Port FirebaseToolApp to App::ui and the unified Panel API; the old App::update, TopBottomPanel and SidePanel were removed in egui 0.35. - Bump the ron dev-dependency to 0.12 so the config migration tests parse with the same ron version eframe persists with. - Raise rust-version and the msrv CI pin from 1.90 to 1.95, the floor egui 0.36 declares. - Take the signing tests' RNG from rsa::rand_core::OsRng and drop the rand dev-dependency. rand 0.9 cannot feed rsa 0.9 (rand_core 0.6). Supersedes Dependabot PRs #25, #26 and #27.
Cargo kept gpu-allocator on the windows 0.58 already in the lockfile, while wgpu-hal 30 builds its DX12 backend against windows 0.62. The two copies' D3D12 types don't match, so wgpu-hal failed to compile on Windows. gpu-allocator 0.28 accepts windows 0.58 through 0.62, so point it at the same 0.62.2 that wgpu-hal uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Upgrades eframe, egui, egui_extras and egui-wgpu from 0.33 to 0.36, replacing Dependabot PRs #25, #26 and #27, which couldn't be merged as opened.
App::update,TopBottomPanelandSidePanel.FirebaseToolAppnow implementsApp::uiand uses the unifiedPanelAPI. The change is confined to theAppimpl insrc/app.rs.rust-version, the msrv CI pin and the docs are raised together, as.github/dependabot.ymlasks.rsa::rand_core::OsRng, so theranddev-dependency is gone.Closes #25, closes #26, closes #27.
Checklist
cargo fmt --all -- --checkpassescargo clippy --all-targets -- -D warningspasses (Rust 1.95,--locked)cargo test --all-targetspasses (42/42)cargo build --releasesucceeds (in Ubuntu 22.04 for the e2e sandbox)CHANGELOG.mdupdated under[Unreleased]Notes for the reviewer
End-to-end tested in a screenenv Ubuntu desktop, comparing this branch with a
mainbuild:main.Known, intentional: the Users panel opens at its default width once after upgrading, because egui 0.36 stores panel state in a new format. This is noted in the changelog.