Repository navigation
vfio-pci: report from realize with the -device location, as QEMU does - #339
Merged
Merged
Conversation
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9.
QEMU realizes a
-devicewith the option's location current, so a warning or error that vfio-pci prints during realize starts with "-device vfio-pci,...: ". ruvm printed the dma-buf warning from #337 without it.realize_x86()now pushes the plug's location for the length of realize, likeqdev_device_add()does, so the dma-buf warnings and "Failed to mmap NAME BAR n. Performance may be slow" carry the same prefix as in QEMU. Errors that realize returns were already printed with the location and do not change.Checked:
-D warningsand--all-targetsfor ruvm-mem, ruvm-hw-iommu, ruvm-sys, ruvm-hw-pci, ruvm-hw-vfio, ruvm-machine-x86, ruvm-machine-arm and ruvm-system, the same clippy for x86_64-pc-windows-gnu and aarch64-apple-darwin, the tests of ruvm-mem, ruvm-hw-iommu, ruvm-sys, ruvm-hw-pci and ruvm-hw-vfio and of the ruvm-machine-x86, ruvm-machine-arm and ruvm-system libs, and xtask unsafe-audit, provenance, layers and style. All passed, with 113 tests in the ruvm-system lib, 43 in ruvm-machine-x86 and 35 in ruvm-machine-arm. ruvm-machine-x86 has 3 fewer than before because machine-arm: migrate the PCI host of virt #338 moved its PCI vmstate tests to ruvm-hw-pci.-device vfio-pci,host=0000:00:04.0,addr=2under-Sand qtest. Both print the same line, byte for byte:Both also got all 778 of 778 answers with the same 71 distinct ones, and the same three mmaps of the device fd.