Skip to content

vfio-pci: report from realize with the -device location, as QEMU does #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamnd merged 2 commits into from
Oct 14, 2026
Merged

vfio-pci: report from realize with the -device location, as QEMU does #339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19fd2c7
vfio-pci: report from realize with the -device location, as QEMU does
tamnd Oct 14, 2026
220ceef
Merge remote-tracking branch 'origin/main' into vfio-warn-loc
tamnd Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/system/src/vfio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,12 @@ pub(crate) fn realize_x86(
) -> Result<(), Located> {
use std::sync::Arc;

use ruvm_base::report::push_location;
use ruvm_hw_pci::regs::PCI_ROM_SLOT;

// qdev_device_add() runs realize with the option's location current, so what realize
// reports itself, such as the dma-buf warning, starts with "-device vfio-pci,...: ".
let _loc = plug.loc.clone().map(push_location);
let X86Board::Q35(m, _) = board else {
return Err(Located::new(
&plug.loc,
Expand Down
Loading