fix: Bugbot findings from promotion PR #397#402
Merged
Conversation
- upgrade: reuse prepareHostInstallerCmd / installerURL (download-then-exec) instead of curl|bash, so stdin stays on the TTY and the URL has one source - upgrade: treat cancelled context / bash exit 130 as a quiet interrupt (exit 130), matching prepare-host Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
aptracebloc
approved these changes
Jul 24, 2026
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Cursor Bugbot findings surfaced on the cli promotion PR (#397, develop → main).
Fixes:
tracebloc upgradenow reuses the shared download-then-execute installer path (prepareHostInstallerCmd) and derives the URL frominstallerURL, so the installer's prompts keep the TTY and the URL has a single source. (Release develop → main #397 (comment))prepare-host, instead of surfacing as a failed upgrade. (Release develop → main #397 (comment))Lands on develop; the promotion PR head picks these up on the next sync and Bugbot re-reviews.
🤖 Generated with Claude Code
Note
Medium Risk
Changes how the CLI invokes the cosign-verified installer on upgrade/prepare-host (stdin, download failure, exit codes); behavior is intentional but affects a privileged, user-facing path.
Overview
Unix
tracebloc upgradenow runs the official installer the same way asprepare-host, via a sharedinstallerRunScripthelper that downloadsi.shto a temp file and executes it (optional subcommand for prepare-host). This replaces the previouscurl … | bashpipeline so installer interactive prompts keep the TTY and failed downloads fail closed instead of exiting 0 on empty stdin.Upgrade’s manual retry hint now reuses
installCmdfrom doctor bootstrap copy instead of a second hardcoded URL, keepinginstallerURLas the single source.Ctrl-C during upgrade is handled like prepare-host:
installerRunInterrupted(renamed fromprepareHostInterrupted) exits quietly with code 130 instead of a failed-upgrade message. Tests were updated to assert no pipe-into-bash, download-then-execute shape, and shared interrupt behavior.Reviewed by Cursor Bugbot for commit 176f15d. Bugbot is set up for automated code reviews on this repo. Configure here.