Repository navigation
Add ambiguous currency symbol presentations (bare dollar, yen, franc) - #141
Merged
Merged
Conversation
Currency symbols gain an optional ambiguous flag for presentations shared across currencies: USD carries the bare dollar sign, CNY the disambiguated CN yuan sign and the bare yen sign (JPY's yen sign is marked ambiguous for the same reason), and CHF the franc Fr. Strict unit consumers skip ambiguous presentations; prose style-enforcement consumers (metanorma-iso house style) match them. Resolves #140, option one: disambiguation stays primary, ambiguity is explicit.
This was referenced Nov 11, 2026
Closed
ronaldtse
added a commit
to unitsml/unitsml-ruby
that referenced
this pull request
Nov 11, 2026
The payload sync guard fails with the new currency symbol data (the ambiguous presentations of unitsml/unitsdb#141); the committed payload is regenerated against the published unitsdb gem 2.2.14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #140, option one: unitsdb stays disambiguation-first, and ambiguity becomes explicit data.
SymbolPresentationgains an optionalambiguousboolean (schema unchanged in effect: additive optional property,schema_versionstays 2.2.0):$(ambiguous: true) alongsideUS$CN¥(unambiguous) and the bare yen sign¥(ambiguous: true)¥is markedambiguous: true(shared with CNY)Fr.(ambiguous: true)Strict-unit consumers keep skipping ambiguous presentations; prose style-enforcement consumers (metanorma-iso house style, metanorma#1707) match them.
Test plan
ruby validate_schemas.rb— all files passunitsdb validate identifiers/references/si_references— green (bundle's unitsdb gem updated to 2.2.13; Gemfile.lock update left uncommitted as tooling)