Add 'type' property to Database resource and update Appwrite source - #103
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant Source as Appwrite Source
participant Database as Database Resource
participant Destination as Appwrite Destination
Source->>Database: Instantiate with type (from $database['type'])
Database->>Source: Database object with type
Source->>Destination: Pass Database object
Destination->>Destination: Create document with type field
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
abnegate
reviewed
Aug 5, 2025
| '$createdAt' => $resource->getCreatedAt(), | ||
| '$updatedAt' => $resource->getUpdatedAt(), | ||
| 'originalId' => empty($resource->getOriginalId()) ? null : $resource->getOriginalId(), | ||
| 'type' => empty($resource->getType()) ? null : $resource->getType(), |
Member
There was a problem hiding this comment.
Let's fallback tosql instead of null here
| updatedAt: $array['updatedAt'] ?? '', | ||
| enabled: $array['enabled'] ?? true, | ||
| originalId: $array['originalId'] ?? '', | ||
| type: $array['type'] ?? '', |
| $database['name'], | ||
| $database['$createdAt'], | ||
| $database['$updatedAt'], | ||
| type:$database['type'] |
abnegate
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit