chore(domains,dns,http,queue): require Validators ^1.0 - #250
Merged
Conversation
ChiragAgg5k
requested review from
Meldiron,
abnegate,
eldadfux and
lohanidamodar
as code owners
September 10, 2026 08:24
This was referenced Sep 10, 2026
Contributor
|
Benchmark resultsdns — transport throughput (4 cores, 250 repeats x 20 workers x 3 domains per transport)
http — Swoole modes (4 cores, 200 VUs, 20s/run)
a = HYPERLOOP_A (process), b = HYPERLOOP_B (coroutine) Shared CI runners — treat absolute numbers as rough, compare modes within a run. Commit 9e148e4. |
loks0n
approved these changes
Sep 10, 2026
Member
Author
|
Released from merged commit
All four Split workflows succeeded. Confirmed all four versions on Packagist with Validators |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require Validators
^1.0exclusively in Domains, DNS, HTTP, and Queue. Remove the older requirements and fallback ranges. No Composer version aliases or runtime compatibility overrides.DNS's test Dockerfile now copies the dependencies already installed by the test runner. Its independent
composer updateused published Domains instead of the linked checkout, making dependent CI fail before a Domains release. The sample image now requires dependencies to be installed before building, as the monorepo runner already does.Part of appwrite/appwrite#13575 and https://github.com/appwrite-labs/cloud/pull/5734. Storage already requires Validators 1.x; the closed #249 workaround was reverted. Each changed package needs a release after merge. Domains must release before DNS/Emails can install with registry-only resolution. Database is handled in utopia-php/database#963; Audit follows in #251.
Verification
PHP 8.5.10:
HTTP_E2E_FPM_URL/HTTP_E2E_SWOOLE_URL; unrelated containers were untouched.XDEBUG_MODE=off. Initial Xdebug-enabled host run exited 139. Queue Redis/NATS E2E was not run locally.XDEBUG_MODE=off bin/monorepo test dns --linked: 181 unit tests / 596 assertions, local Docker E2E 34 tests / 304 assertions, passed. This uses the monorepo's existing linked-sibling test mode, not a published dependency graph.bin/monorepo check domains http queueandbin/monorepo check dns: Pint, PHPStan, Rector passed.bin/monorepo validateandgit diff --check: passed.The runner uses
--ignore-platform-reqsfor installation. No package lockfiles or generated linked manifests are committed. Downstream CE/Cloud application verification remains blocked on other prerequisite releases. Backend-only; no screenshots apply. No merges, releases or deployments performed.