Skip to content

chore(audit): require Validators ^1.0 - #251

Merged
ChiragAgg5k merged 3 commits into
mainfrom
chore/audit-dns-validators-1
Sep 10, 2026
Merged

chore(audit): require Validators ^1.0#251
ChiragAgg5k merged 3 commits into
mainfrom
chore/audit-dns-validators-1

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary

Require Validators ^1.0 exclusively in Audit. No aliases or fallback ranges. Part of appwrite/appwrite#13575 and https://github.com/appwrite-labs/cloud/pull/5734.

Database 7.3.7 is now released, so Audit resolves and has been tested against published Database 7.3.7 and Validators 1.0.1. Updated this branch with main after #250 merged; DNS remains in that merged PR, not this diff.

Audit needs a release after merge before CE and Cloud can resolve the remaining dependency conflicts.

Verification

PHP 8.5.10, registry-resolved dependencies (no linked mode):

  • XDEBUG_MODE=off bin/monorepo test audit: 22 unit tests / 106 assertions and local MariaDB/ClickHouse E2E 91 tests / 979 assertions, passed. E2E reported 3 deprecations; no failures/errors. Fixture containers were removed by the runner.
  • bin/monorepo check audit: Pint, PHPStan, Rector passed.
  • bin/monorepo validate and git diff --check: passed.

The runner uses --ignore-platform-reqs for dependency installation. No package lockfiles are committed. No downstream application E2E, merges, releases or deployments performed in this update. Backend-only; no screenshots apply.

@ChiragAgg5k ChiragAgg5k changed the title chore(audit,dns): require Validators ^1.0 chore(audit): require Validators ^1.0 Sep 10, 2026
@ChiragAgg5k
ChiragAgg5k marked this pull request as ready for review September 10, 2026 10:57
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the dependency constraint aligns with Audit’s platform requirement and its direct Validators usage remains compatible.

Summary

  • Replaces the ^0.6 Validators constraint with ^1.0.
  • Preserves Audit’s existing PHP and runtime dependency declarations.
  • Does not change Audit runtime code or tests.

Reviews (1) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..."

@ChiragAgg5k
ChiragAgg5k merged commit 2e3f1a2 into main Sep 10, 2026
6 checks passed
@ChiragAgg5k

Copy link
Copy Markdown
Member Author

Merged after all checks passed and released Audit 4.0.3 from merge commit 2e3f1a2ba5f6d3b23abdcd8f5f1978a87fa86391. Split workflow succeeded; confirmed Packagist indexes 4.0.3 with Validators ^1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants