[vitali87]

Summary

In split, the "Clean up and proceed with re-splitting?" step — which closes the existing sub-PRs, deletes their remote branches and removes the plan — ran before Settings(...) was constructed. An invalid option pair (--min-loc 500 --max-loc 400), a missing ANTHROPIC_API_KEY, or a negative --max-refinement-iterations was therefore only reported after the user's live PRs had already been destroyed, with nothing re-created.

Settings depends only on CLI options and the environment, so its construction (and the existing clean error handling) now happens right after _validate_inputs, before anything destructive.

Stacked on #111 (fix/split-dry-run-preamble), which owns the surrounding cleanup block.

Test plan

• test_bad_settings_never_reach_the_destructive_cleanup: with an executed plan on disk and --min-loc 500 --max-loc 400, exit 1 with the settings error and neither the confirm prompt, _cleanup_git_state, nor extract_diff is reached — fails on the base
• the dry-run refusal test now supplies an API key since settings validate first
• Review confirmed --dry-run --partition-strategy graph without an API key still works, and execute has no equivalent hazard
• 449 tests pass, ruff clean
• Local review: 5/5

[coderabbitai]

Warning

Review limit reached

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0ae56f97-3051-42a5-947d-9f2866bd60b0

📥 Commits

Reviewing files that changed from the base of the PR and between 7b4f14f and e8a1c7b.

⛔ Files ignored due to path filters (1)

• uv.lock is excluded by !**/*.lock

📒 Files selected for processing (64)

• .github/workflows/split-score.yml
• README.md
• action.yml
• pr_split/cli.py
• pr_split/config.py
• pr_split/constants.py
• pr_split/diff_ops/new_file_split.py
• pr_split/diff_ops/parser.py
• pr_split/diff_ops/reconstructor.py
• pr_split/exceptions.py
• pr_split/git_ops/__init__.py
• pr_split/git_ops/branches.py
• pr_split/git_ops/prs.py
• pr_split/graph.py
• pr_split/logs.py
• pr_split/per_group.py
• pr_split/plan_store.py
• pr_split/planner/__init__.py
• pr_split/planner/chunker.py
• pr_split/planner/client.py
• pr_split/planner/new_file_pieces.py
• pr_split/planner/partitioning.py
• pr_split/planner/repair.py
• pr_split/planner/scoring.py
• pr_split/planner/symbols.py
• pr_split/planner/validator.py
• pr_split/recover.py
• pr_split/restack.py
• pr_split/schemas.py
• pr_split/stack_move.py
• pyproject.toml
• scripts/score_pr.py
• tests/conftest.py
• tests/network_guards.py
• tests/test_chunker.py
• tests/test_cli_coverage.py
• tests/test_cli_helpers.py
• tests/test_cli_new_features.py
• tests/test_client.py
• tests/test_config.py
• tests/test_default_strategy.py
• tests/test_description_refresh.py
• tests/test_diff_base.py
• tests/test_diff_parser_extended.py
• tests/test_git_branches.py
• tests/test_git_prs.py
• tests/test_git_prs_coverage.py
• tests/test_graph.py
• tests/test_local_provider.py
• tests/test_new_file_split.py
• tests/test_partitioning.py
• tests/test_per_group.py
• tests/test_plan_store.py
• tests/test_reconstructor.py
• tests/test_recover.py
• tests/test_repair.py
• tests/test_restack.py
• tests/test_schemas.py
• tests/test_score_pr.py
• tests/test_score_pr_events.py
• tests/test_scoring.py
• tests/test_stack_move.py
• tests/test_symbols.py
• tests/test_validator.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[vitali87]

This change is already in main: it landed via the merge train #243, which includes this PR's head commit. GitHub can't mark a stacked PR merged when it lands that way, so I'm closing it as done.

---

Generated by Claude Code