Repository navigation
fix: refresh a stale score comment when the PR shrinks below the threshold - #89
Merged
3 commits merged intoSep 27, 2026
Merged
3 commits merged into
3 commits merged into
Conversation
…shold The comment step only ran when should_split was true, so once a PR was pushed back under the limit its old '<!-- pr-split-score -->' comment with the split plan stayed. The script now writes a 'within limits' body on every skip, and the action updates an existing marker comment regardless of should_split while still only creating one when a split is suggested. Non-PR events are skipped in the step itself.
… path Failure-path skips (pr-split error, missing plan) must not produce a body, or a transient failure would overwrite a valid split-plan comment with a false 'within limits' message.
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Main already factored out _write_comment and now flags oversized PRs with a comment on planner failure, so only the under-threshold refresh remains: _skip(within_limits=True) writes a marker comment via main's helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rnEEjXWDBdePRhKMmZr1w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
action.ymlran the "Post comment" step only whenshould_split == 'true'. Once a PR had been flagged and the author pushed it back undermax-loc, the script took the_skippath, wrote no comment body, and the old<!-- pr-split-score -->comment with the now-wrong split plan stayed on the PR forever.Fix
scripts/score_pr.py: comment writing is factored into_write_comment; the under-threshold_skip(..., within_limits=True)writes a short "within acceptable size limits" body carrying the marker. The two failure-path skips (pr-spliterror, missing plan) deliberately write no body, so a transient failure can never overwrite a valid plan comment.action.yml: the step runs whenevercomment_pathis set, returns early on non-PR payloads, updates an existing marker comment regardless ofshould_split, and only creates one whenSHOULD_SPLIT == 'true'(so small PRs that were never flagged stay quiet).Tests
comment_pathcomment_pathmain()with a failing stubpr-spliton a 500-LOC diff writes nocomment_pathmain()with a stub that writes a 2-group plan produces a marker-prefixed body with the group tableLocal review: 5/5 (the github-script branching was simulated for all five cases). 448 tests pass, ruff clean.