Repository navigation
fix: exit 1 when a PR's state could not be fetched during merge - #98
Merged
3 commits merged intoSep 27, 2026
Merged
3 commits merged into
3 commits merged into
Conversation
A get_pr_state failure was recorded as a skip and the run still ended with exit 0 and 'Merge complete', so a broken gh session or transient API error looked like success to scripts and webhooks. Report the affected groups, exit 1, and send exit_reason=fetch_error.
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 30, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rnEEjXWDBdePRhKMmZr1w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
get_pr_statereturned nothing (expiredghsession, API hiccup),mergelogged a warning, recorded the group as skipped, and still finished with exit 0 and "Merge complete". Scripts and the webhook saw success for a run that never verified — let alone merged — the PR. The--autopolling path had the same gap: a fetch error while waiting was discarded and surfaced only as a genericincomplete_batch.Fix
fetch_errors; the summary printsCould not fetch PR state for (N): … Check 'gh auth status' and re-run, the webhook getsexit_reason: "fetch_error"/success: false, and the command exits 1.--autopath:_poll_for_mergedreports polling fetch errors to the caller, which records them infetch_errorsandskippedlike the sync path (siblings in the batch still merge).fetch_erroroutranksunmerged_dependencyin the webhook reason, since blocked children caused by an unfetchable parent are a symptom, not something "re-run once merged" fixes.Tests
Unfetchable sibling → exit 1, no "Merge complete",
fetch_error; unfetchable parent with a child →fetch_error(notunmerged_dependency); fetch error during--autopolling →fetch_errorwith the group inskipped. All fail on base.Local review: 5/5. 452 tests pass, ruff clean. Stacked on #67.