Repository navigation
Conversation
1.10.0 copied NSPopover's frostier glass by setting NSGlassEffectView's private _variant to 20. macOS 27.2 renumbered those variants, so 20 now renders a clear lens: the panel goes see-through, its edge columns, search field and tab bar refract out of view, and the corners frost into wedges. On 27.0, variant 19 reproduces the reporter's screenshot exactly. The responds(to:) guard only covered the key disappearing, not this. Light mode now uses the public .clear style under the existing 0.25 white veil. On 27.0 that measures the same as the shipped look (~247 over white, ~117 over black) and blurs text behind it just as heavily. Dark mode stays on unveiled .regular glass, as before. Refs: W-990
wr
enabled auto-merge (squash)
October 6, 2026 05:05
wr
deleted the
wells/w-990-excessive-transparency-and-emoji-incorrectly-showing-on-0100
branch
October 6, 2026 05:08
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the see-through, clipped picker that light-mode users see on macOS 27.2 with 1.10.0 (#230).
Cause
1.10.0 copied NSPopover's frostier glass by setting the private
NSGlassEffectView._variantto 20 (#214). macOS 27.2 renumbered those private variants, so 20 now renders a clear lens:On 27.0, variant 19 reproduces the reporter's screenshot exactly. The
responds(to:)guard only covered the key disappearing, not its numbers changing meaning. Dark mode never set the variant, so it was unaffected.Fix
Drop the private call. Light mode now uses the public
.clearglass style under the existing 0.25 white veil. Dark mode stays on unveiled.regularglass, as before. This covers every panel built onPopoverGlass: the list picker, the Quick Access pill, the emoji browser and the GIF panel.On 27.0,
.clearwith the veil measures the same as the shipped look (~247 over white, ~117 over black) and blurs the page behind it just as heavily. Standard glass with the veil reads greyer over white and turns into a light slab over dark pages.Test plan
scripts/run-tests.sh.clearholds.Refs W-990