Skip to content

Require explicit build optimization flags - #1260

Merged
Frotty merged 1 commit into
masterfrom
codex/build-flags-opt-in
Aug 28, 2026
Merged

Require explicit build optimization flags#1260
Frotty merged 1 commit into
masterfrom
codex/build-flags-opt-in

Conversation

@Frotty

@Frotty Frotty commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

  • stop Build Map from unconditionally enabling opt, inline, and localOptimizations
  • require each build-only optimization to have its corresponding + entry in wurst_run.args
  • update the regression test to prove an omitted +opt stays disabled

Acceptance criteria

  • +inline enables inline only for builds
  • +localOptimizations enables local optimizations only for builds
  • omitted +opt does not enable output optimization

Checks

  • ./gradlew.bat test --tests tests.wurstscript.tests.WurstCommandsTests — passed
  • git diff --check — passed

Known gaps

  • none

@Frotty

Frotty commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 782f826563

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Frotty
Frotty merged commit a72f375 into master Aug 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant