Skip to content

Require explicit build optimization flags #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frotty merged 1 commit into from
Aug 28, 2026
Merged

Require explicit build optimization flags #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions de.peeeq.wurstscript/src/main/java/de/peeeq/wurstio/languageserver/WurstCommands.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,6 @@ public static List<String> getCompileArgs(WFile rootPath, boolean forBuild, Stri
.filter(s -> s.startsWith("-") || (forBuild && s.startsWith("+")))
.map(s -> forBuild && s.startsWith("+") ? "-" + s.substring(1) : s)
.collect(Collectors.toList()));
if (forBuild) {
addBuildDefault(args, "-opt");
addBuildDefault(args, "-inline");
addBuildDefault(args, "-localOptimizations");
}
args.addAll(List.of(additionalArgs));
return WurstBuildConfig.fromWorkspaceRoot(rootPath).applyToCompileArgs(args);
}
Expand All @@ -166,10 +161,4 @@ public static List<String> getCompileArgs(WFile rootPath, boolean forBuild, Stri
}
}

private static void addBuildDefault(List<String> args, String option) {
if (!args.contains(option)) {
args.add(option);
}
}

}
2 changes: 1 addition & 1 deletion de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/WurstCommandsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public void buildOnlyRunArgsAreExcludedFromRunAndEnabledForBuild() throws Except
assertTrue(buildArgs.contains("-stacktraces"));
assertTrue(buildArgs.contains("-inline"));
assertTrue(buildArgs.contains("-localOptimizations"));
assertTrue(buildArgs.contains("-opt"), "builds enable output optimization by default");
assertFalse(buildArgs.contains("-opt"), "build options require their corresponding '+' entry");
}

@Test
Expand Down
Loading