Repository navigation
feat(modules): spec 015 image sources and real digests for nine new modules - #48
Merged
Merged
Conversation
github.repository_owner is GameplanePanel, and OCI references must be lowercase, so a signed push to ghcr.io/GameplanePanel/gameplane was an invalid reference. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
- Use ghcr.io/acemod/arma-reforger pinned by digest instead of a Gameplane image that was never built (spec 015 T133/T135). - The image runs as root for SteamCMD: drop spec.security and the HOME override. - Mount /reforger (install, Configs, profile, workshop); ARMA_PROFILE and ARMA_WORKSHOP_DIR point inside it; mods path is workshop. - Config keys follow the image: GAME_NAME, GAME_PASSWORD, GAME_PASSWORD_ADMIN, GAME_MAX_PLAYERS. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
…ne-built images These four run on images built from images/games/<name> in the main repo on the shared SteamCMD base (spec 015 T134/T136/T137/T139): - runAsUser/runAsGroup/fsGroup 10000 to match the base's gameserver user; HOME comes from the image. - The volume mounts at /data and holds the whole install, which SteamCMD downloads on first start. - Squad mods path is SquadGame/Plugins/Mods. Image refs still hold placeholders until the images are published and pinned (T141). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ages Repoint the four Gameplane-built images to ghcr.io/gameplanepanel/gameplane (published and cosign-signed by GameplanePanel/Gameplane#638) and replace the placeholder digest with the real one (T141). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
…ain repo Their Dockerfiles and entrypoints now live in GameplanePanel/Gameplane containers/games/, which publishes and signs them. Drop the local copies, build-images.sh and the build-images workflow (it had no signing key and never pushed), and point the four templates at ghcr.io/gameplanepanel/gameplane. Digests are pinned once the images are published. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Replace the placeholder digest with the real one for the four images published and cosign-signed by GameplanePanel/Gameplane#651 (T141). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
ValgulNecron
marked this pull request as ready for review
October 11, 2026 02:25
ValgulNecron
changed the title
ValgulNecron
pushed a commit
to GameplanePanel/Gameplane
that referenced
this pull request
Oct 11, 2026
…docs Bump the modules submodule to GameplanePanel/module#48 (real digests for nine of the ten placeholder templates). Re-read engine-matrix-resolved.md from the shipped templates and buckets.sh (T143), mark plan.md Known Gaps 1-4 resolved and update research.md's shipped state (T144), and mark T141-T146 done. hell-let-loose stays open pending its image ruling (T133/T138). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: ten new templates point at
ghcr.io/valgulnecron/gameplane/<game>images that were never published, with placeholdersha256:000…digests.After: nine of them run real, digest-pinned images. Arma Reforger uses the ACE team's
ghcr.io/acemod/arma-reforger. Squad, The Isle, ARK SE, Bannerlord, FiveM, BeamMP, Farming Simulator 25 and Euro Truck Simulator 2 use Gameplane-built images published and cosign-signed toghcr.io/gameplanepanel/gameplaneby GameplanePanel/Gameplane#638 and #651.validate.pyreports 0 errors across all 30 modules.How:
spec.securityis dropped. The volume mounts at/reforgerand config keys follow the image (GAME_NAME,GAME_PASSWORD,GAME_PASSWORD_ADMIN,GAME_MAX_PLAYERS)./datavolume; Squad's mods path becomesSquadGame/Plugins/Mods. These five are bumped to 1.1.0.build-images.shandbuild-images.ymlare removed: their sources now live in the main repo'scontainers/games/, which can sign and push (this repo's workflow had no signing key and never published them).🤖 Generated with Claude Code