Repository navigation
fix: verify disabled subagents before local admission - #448
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 30, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local child admission checked launch-setting provenance but accepted effective
multi_agentandmulti_agent_v2values that enabled unqualified subagents. Require both effective values to be literal false before opening a native thread. Enabled, missing, null and malformed values are refused by key. Older CLIs that omit these flags are intentionally refused.Ten pure-policy regressions failed before the repair. The 26-case focused policy/execution suite passes, including assertions that refused configurations send no
thread/startorturn/startand record no admitted provenance.pnpm build && pnpm testpassed atf58a1b7e86cd33f1d8ef68a3fe2f827202157386with 2,254 passes, 26 skips and zero failures. Independent review found no blocking findings. Head97d8ff6d15c4ecacbcdf9bba57b3fab12c64075eonly relocates the status paragraph to avoid conflicts with pending PRs; production and test code are unchanged. A merge preflight against PR #447's integrated head is clean.A configuration-only probe of installed codex-cli 0.166.0 in a temporary empty home confirmed explicit false values and session-flag origins. No thread, prompt or inference was involved. This does not establish native offline or subagent execution acceptance, and product local execution remains unadmitted. The other #380 criteria remain open.
Evidence:
docs/reviews/2026-10-30-lm5-subagent-policy.mdand its trimmed configuration receipt.Hosted validation passed for this exact head: macOS job
123963060083passed 478 desktop cases with four skips (21.8 minutes) and seven site cases (17.1 seconds); transcript median 228.2 ms. Windows, Linux, iPhone and CodeQL checks also passed. The exact head has been submitted to the protected merge queue without bypass; queue validation and merge remain pending.